chrome/browser/notifications/native_notification_display_service.cc - Issue 2875673002: Minimize the delegate dependencies for native extension notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/native_notification_display_service.cc

Issue 2875673002: Minimize the delegate dependencies for native extension notifications. (Closed)

Patch Set: review Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/notifications/notifications_apitest.cc ('K') | « chrome/browser/extensions/api/notifications/notifications_apitest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/native_notification_display_service.cc

diff --git a/chrome/browser/notifications/native_notification_display_service.cc b/chrome/browser/notifications/native_notification_display_service.cc

index 69d06a11a7b3e404674a689e971d58264541912b..2ffcd75fd3929c32998c54c28a73145fdbef9796 100644

--- a/chrome/browser/notifications/native_notification_display_service.cc

+++ b/chrome/browser/notifications/native_notification_display_service.cc

@@ -60,8 +60,9 @@ NativeNotificationDisplayService::NativeNotificationDisplayService(

AddNotificationHandler(NotificationCommon::PERSISTENT,

base::MakeUnique<PersistentNotificationHandler>());

#if BUILDFLAG(ENABLE_EXTENSIONS)

- AddNotificationHandler(NotificationCommon::EXTENSION,

- base::MakeUnique<ExtensionNotificationHandler>());

+ AddNotificationHandler(

+ NotificationCommon::EXTENSION,

+ base::MakeUnique<extensions::ExtensionNotificationHandler>());

dewittj 2017/05/16 22:07:17 Depending on where else this type is referenced, i

Miguel Garcia 2017/05/20 07:04:10 I've noticed this pattern with the notification de

#endif

}