Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: chrome/browser/extensions/api/notifications/extension_notification_handler.h

Issue 2875673002: Minimize the delegate dependencies for native extension notifications. (Closed)
Patch Set: review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/notifications/extension_notification_handler.h
diff --git a/chrome/browser/extensions/api/notifications/extension_notification_handler.h b/chrome/browser/extensions/api/notifications/extension_notification_handler.h
index 9d6985ff7e86baffb96f536e775f17e55857d030..6e6cb2cb8097408c4b1c03670e3bfa9446dc39bf 100644
--- a/chrome/browser/extensions/api/notifications/extension_notification_handler.h
+++ b/chrome/browser/extensions/api/notifications/extension_notification_handler.h
@@ -6,20 +6,45 @@
#define CHROME_BROWSER_EXTENSIONS_API_NOTIFICATIONS_EXTENSION_NOTIFICATION_HANDLER_H_
#include "base/macros.h"
-#include "chrome/browser/notifications/non_persistent_notification_handler.h"
+#include "chrome/browser/notifications/notification_handler.h"
+#include "extensions/browser/event_router.h"
+
+class Profile;
+
+namespace extensions {
// Handler for notifications shown by extensions. Will be created and owned by
-// the NotificationDisplayService.
-class ExtensionNotificationHandler : public NonPersistentNotificationHandler {
+// the NativeNotificationDisplayService.
+class ExtensionNotificationHandler : public NotificationHandler {
public:
ExtensionNotificationHandler();
~ExtensionNotificationHandler() override;
// NotificationHandler implementation.
+ void OnClose(Profile* profile,
+ const std::string& origin,
+ const std::string& notification_id,
+ bool by_user) override;
+ void OnClick(Profile* profile,
+ const std::string& origin,
+ const std::string& notification_id,
+ int action_index,
+ const base::NullableString16& reply) override;
void OpenSettings(Profile* profile) override;
+ void RegisterNotification(const std::string& notification_id,
+ NotificationDelegate* delegate) override;
private:
+ void SendEvent(Profile* profile,
+ const std::string& extension_id,
+ events::HistogramValue histogram_value,
+ const std::string& name,
+ EventRouter::UserGestureState user_gesture,
+ std::unique_ptr<base::ListValue> args);
+
DISALLOW_COPY_AND_ASSIGN(ExtensionNotificationHandler);
};
+} // namespace extensions
+
#endif // CHROME_BROWSER_EXTENSIONS_API_NOTIFICATIONS_EXTENSION_NOTIFICATION_HANDLER_H_

Powered by Google App Engine
This is Rietveld 408576698