Minimize the delegate dependencies for native extension notifications.

chrome/browser/extensions/api/notifications/extension_notification_handler.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_NOTIFICATIONS_EXTENSION_NOTIFICATION_HANDLER_H_
 #define CHROME_BROWSER_EXTENSIONS_API_NOTIFICATIONS_EXTENSION_NOTIFICATION_HANDLER_H_
 
 #include "base/macros.h"
-#include "chrome/browser/notifications/non_persistent_notification_handler.h"
+#include "chrome/browser/notifications/notification_handler.h"
+
+#include "extensions/browser/event_router.h"

[Peter Beverloo, 2017/05/15 15:56:52]

nit: no blank line

[Miguel Garcia, 2017/05/16 11:01:34]

Done.

+
+class Profile;
+
+namespace extensions {
 
 // Handler for notifications shown by extensions. Will be created and owned by
-// the NotificationDisplayService.
-class ExtensionNotificationHandler : public NonPersistentNotificationHandler {
+// the NativeNotificationDisplayService.
+class ExtensionNotificationHandler : public NotificationHandler {
  public:
   ExtensionNotificationHandler();
   ~ExtensionNotificationHandler() override;
 
-  // NotificationHandler implementation.

[Peter Beverloo, 2017/05/15 15:56:52]

Please keep this. Also remove the blank lines on :28, :34, :36 since the comment
applies to all these methods. (This is common throughout Chrome.)

[Miguel Garcia, 2017/05/16 11:01:34]

Done.

+  void OnClose(Profile* profile,
+               const std::string& origin,
+               const std::string& notification_id,
+               bool by_user) override;
+
+  void OnClick(Profile* profile,
+               const std::string& origin,
+               const std::string& notification_id,
+               int action_index,
+               const base::NullableString16& reply) override;
+
   void OpenSettings(Profile* profile) override;
 
+  void RegisterNotification(const std::string& notification_id,
+                            NotificationDelegate* delegate) override;
+
  private:
+  void SendEvent(Profile* profile,
+                 const std::string& extension_id,
+                 events::HistogramValue histogram_value,
+                 const std::string& name,
+                 EventRouter::UserGestureState user_gesture,
+                 std::unique_ptr<base::ListValue> args);
+
   DISALLOW_COPY_AND_ASSIGN(ExtensionNotificationHandler);
 };
 
+}  // namespace extensions
 #endif  // CHROME_BROWSER_EXTENSIONS_API_NOTIFICATIONS_EXTENSION_NOTIFICATION_HANDLER_H_

[Peter Beverloo, 2017/05/15 15:56:52]

nit: blank line after 51

[Miguel Garcia, 2017/05/16 11:01:34]

Done.