Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h

Issue 2875583002: AccessorConfiguration and AttributeConfiguration no longer need the same fields. (Closed)
Patch Set: whitespace changes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 76
77 // AttributeConfiguration translates into calls to SetNativeDataProperty() on 77 // AttributeConfiguration translates into calls to SetNativeDataProperty() on
78 // either the instance or the prototype ObjectTemplate, based on 78 // either the instance or the prototype ObjectTemplate, based on
79 // |propertyLocationConfiguration|. 79 // |propertyLocationConfiguration|.
80 struct AttributeConfiguration { 80 struct AttributeConfiguration {
81 AttributeConfiguration& operator=(const AttributeConfiguration&) = delete; 81 AttributeConfiguration& operator=(const AttributeConfiguration&) = delete;
82 DISALLOW_NEW(); 82 DISALLOW_NEW();
83 const char* const name; 83 const char* const name;
84 v8::AccessorNameGetterCallback getter; 84 v8::AccessorNameGetterCallback getter;
85 v8::AccessorNameSetterCallback setter; 85 v8::AccessorNameSetterCallback setter;
86 // TODO(vogelheim): This has to be removed too since it's only used in 86
87 // accessors.
88 // The accessor's 'result' is stored in a private property.
89 CachedPropertyKey cached_property_key;
90 const WrapperTypeInfo* data; 87 const WrapperTypeInfo* data;
91 // v8::PropertyAttribute 88 // v8::PropertyAttribute
92 unsigned attribute : 8; 89 unsigned attribute : 8;
93 // PropertyLocationConfiguration 90 // PropertyLocationConfiguration
94 unsigned property_location_configuration : 3; 91 unsigned property_location_configuration : 3;
95 // HolderCheckConfiguration 92 // HolderCheckConfiguration
96 unsigned holder_check_configuration : 1; 93 unsigned holder_check_configuration : 1;
97 // WorldConfiguration 94 // WorldConfiguration
98 unsigned world_configuration : 2; 95 unsigned world_configuration : 2;
99 }; 96 };
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 // Sets the class string of platform objects, interface prototype objects, 325 // Sets the class string of platform objects, interface prototype objects,
329 // etc. See also http://heycam.github.io/webidl/#dfn-class-string 326 // etc. See also http://heycam.github.io/webidl/#dfn-class-string
330 static void SetClassString(v8::Isolate*, 327 static void SetClassString(v8::Isolate*,
331 v8::Local<v8::ObjectTemplate>, 328 v8::Local<v8::ObjectTemplate>,
332 const char* class_string); 329 const char* class_string);
333 }; 330 };
334 331
335 } // namespace blink 332 } // namespace blink
336 333
337 #endif // V8DOMConfiguration_h 334 #endif // V8DOMConfiguration_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698