Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: recipe_modules/step/example.expected/exceptional.json

Issue 2875543002: [recipe_modules/step] do not set cwd if it is start_dir. (Closed)
Patch Set: fix take 2 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 [ 1 [
2 { 2 {
3 "cmd": [ 3 "cmd": [
4 "echo", 4 "echo",
5 "Hello World" 5 "Hello World"
6 ], 6 ],
7 "name": "hello" 7 "name": "hello"
8 }, 8 },
9 { 9 {
10 "cmd": [ 10 "cmd": [
11 "echo", 11 "echo",
12 "Why hello, there." 12 "Why hello, there."
13 ], 13 ],
14 "name": "hello (2)" 14 "name": "hello (2)"
15 }, 15 },
16 { 16 {
17 "cmd": [ 17 "cmd": [
18 "mkdir",
19 "something"
20 ],
21 "name": "mk subdir"
22 },
23 {
24 "cmd": [
25 "bash",
26 "-c",
27 "echo Why hello, there, in a subdir."
28 ],
29 "cwd": "[START_DIR]/something",
30 "name": "something"
31 },
32 {
33 "cmd": [
34 "bash",
35 "-c",
36 "echo what happen"
37 ],
38 "name": "start_dir ignored"
39 },
40 {
41 "cmd": [
18 "bash", 42 "bash",
19 "-c", 43 "-c",
20 "echo Good bye, $friend." 44 "echo Good bye, $friend."
21 ], 45 ],
22 "env": { 46 "env": {
23 "friend": "Darth Vader" 47 "friend": "Darth Vader"
24 }, 48 },
25 "name": "goodbye" 49 "name": "goodbye"
26 }, 50 },
27 { 51 {
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 "step returned non-zero exit code: 1", 97 "step returned non-zero exit code: 1",
74 "@@@STEP_FAILURE@@@" 98 "@@@STEP_FAILURE@@@"
75 ] 99 ]
76 }, 100 },
77 { 101 {
78 "name": "$result", 102 "name": "$result",
79 "reason": "Uncaught Exception: ValueError('goodbye must exit 0!',)", 103 "reason": "Uncaught Exception: ValueError('goodbye must exit 0!',)",
80 "status_code": -1 104 "status_code": -1
81 } 105 }
82 ] 106 ]
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698