cc: Set requires high res upon becoming visible

cc: Set requires high res upon becoming visible

We should delay setting the flag that we require high res tiles to draw
until we become visible. The reason for this is that when invisible,
we could still activate which would cause us to reset the high res flag.
By delaying setting this until we're visible, we ensure that the flag
is active at the earliest time when we kick off the raster system again.

BUG=371624
R=enne, reveman

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270209

[vmpstr, 2014-05-13 17:33:52]

Please take a look.

[reveman, 2014-05-13 17:41:10]

lgtm % enne's review

[danakj, 2014-05-13 17:42:32]

Could we test this?

[vmpstr, 2014-05-13 17:42:58]

On 2014/05/13 17:42:32, danakj wrote:
> Could we test this?

Of course!

[vmpstr, 2014-05-13 17:52:10]

PTAL. Let me know if you want a more involved test

[danakj, 2014-05-13 18:14:26]

LGTM

https://codereview.chromium.org/287553003/diff/40001/cc/trees/layer_tree_host...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/287553003/diff/40001/cc/trees/layer_tree_host...
cc/trees/layer_tree_host_impl_unittest.cc:5745: 
can you verify the state of RequiresHighResToDraw before the SetVisible(false)
too?

[enne (OOO), 2014-05-13 18:21:53]

lgtm

https://codereview.chromium.org/287553003/diff/40001/cc/trees/layer_tree_host...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/287553003/diff/40001/cc/trees/layer_tree_host...
cc/trees/layer_tree_host_impl.cc:1743:
active_tree()->SetRequiresHighResToDraw();
I was originally going to suggest that maybe we set this flag on both trees when
not visible.

However, I think this is slightly better because it means we could have a fast
activation when not visible and there are no resources.  (Maybe we consider
auto-activating when not visible, honestly.)

[danakj, 2014-05-13 18:23:13]

https://codereview.chromium.org/287553003/diff/40001/cc/trees/layer_tree_host...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/287553003/diff/40001/cc/trees/layer_tree_host...
cc/trees/layer_tree_host_impl.cc:1743:
active_tree()->SetRequiresHighResToDraw();
On 2014/05/13 18:21:53, enne wrote:
> I was originally going to suggest that maybe we set this flag on both trees
when
> not visible.
> 
> However, I think this is slightly better because it means we could have a fast
> activation when not visible and there are no resources.  (Maybe we consider
> auto-activating when not visible, honestly.)

Or when becoming visible. +1 to that either way.

[vmpstr, 2014-05-13 18:24:18]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2014-05-13 18:24:47]

On 2014/05/13 18:23:13, danakj wrote:
>
https://codereview.chromium.org/287553003/diff/40001/cc/trees/layer_tree_host...
> File cc/trees/layer_tree_host_impl.cc (right):
> 
>
https://codereview.chromium.org/287553003/diff/40001/cc/trees/layer_tree_host...
> cc/trees/layer_tree_host_impl.cc:1743:
> active_tree()->SetRequiresHighResToDraw();
> On 2014/05/13 18:21:53, enne wrote:
> > I was originally going to suggest that maybe we set this flag on both trees
> when
> > not visible.
> > 
> > However, I think this is slightly better because it means we could have a
fast
> > activation when not visible and there are no resources.  (Maybe we consider
> > auto-activating when not visible, honestly.)
> 
> Or when becoming visible. +1 to that either way.

Right now it should be a quick turn-around with manage tiles as 0 memory limit,
but yeah instant is better than not instant

[commit-bot: I haz the power, 2014-05-13 18:25:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vmpstr@chromium.org/287553003/60001

[commit-bot: I haz the power, 2014-05-13 21:30:06]

Change committed as 270209