Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Unified Diff: chrome/gpu/arc_gpu_video_decode_accelerator.cc

Issue 2875453002: Add a size parameter to SharedMemoryHandle. (Closed)
Patch Set: Remove extraneous period. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/field_trial.cc ('k') | components/exo/wayland/server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/gpu/arc_gpu_video_decode_accelerator.cc
diff --git a/chrome/gpu/arc_gpu_video_decode_accelerator.cc b/chrome/gpu/arc_gpu_video_decode_accelerator.cc
index 63e8ff83e7a913f0bb076255aedb6b28c8b4f091..9abb435ca1864da71dce12c8a67a33011fb7dea8 100644
--- a/chrome/gpu/arc_gpu_video_decode_accelerator.cc
+++ b/chrome/gpu/arc_gpu_video_decode_accelerator.cc
@@ -297,13 +297,15 @@ void ArcGpuVideoDecodeAccelerator::UseBuffer(PortType port,
}
CreateInputRecord(bitstream_buffer_id, index, metadata.timestamp);
// TODO(rockot): Pass GUIDs through Mojo. https://crbug.com/713763.
- // TODO(erikchen): This fd comes from a mojo::ScopedHandle in
+ // TODO(rockot): This fd comes from a mojo::ScopedHandle in
// GpuArcVideoService::BindSharedMemory. That should be passed through,
// rather than pulling out the fd. https://crbug.com/713763.
+ // TODO(rockot): Pass through a real size rather than |0|.
base::UnguessableToken guid = base::UnguessableToken::Create();
vda_->Decode(media::BitstreamBuffer(
bitstream_buffer_id,
- base::SharedMemoryHandle(base::FileDescriptor(dup_fd, true), guid),
+ base::SharedMemoryHandle(base::FileDescriptor(dup_fd, true), 0u,
+ guid),
metadata.bytes_used, input_info->offset));
break;
}
« no previous file with comments | « base/metrics/field_trial.cc ('k') | components/exo/wayland/server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698