chrome/browser/ui/omnibox/omnibox_edit_model.cc - Issue 287543002: Remove origin chip v1 and "hide on input" v2 behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_edit_model.cc

Issue 287543002: Remove origin chip v1 and "hide on input" v2 behavior. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/omnibox/omnibox_edit_model.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.cc b/chrome/browser/ui/omnibox/omnibox_edit_model.cc

index 587dd72386e3a10288ba621f07704dd623f37872..1e81c188796ff4cd675b59be16e7a7bbeb381b7e 100644

--- a/chrome/browser/ui/omnibox/omnibox_edit_model.cc

+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.cc

@@ -518,7 +518,7 @@ void OmniboxEditModel::SetInputInProgress(bool in_progress) {

// * For HIDE_ON_MOUSE_RELEASE, which only hides the chip on mouse release if

// the omnibox is empty, it handles the "omnibox was not empty" case by

// acting like HIDE_ON_USER_INPUT.

- if (chrome::ShouldDisplayOriginChipV2() && in_progress)

+ if (chrome::ShouldDisplayOriginChip() && in_progress)

controller()->GetToolbarModel()->set_origin_chip_enabled(false);

controller_->GetToolbarModel()->set_input_in_progress(in_progress);