Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2875373002: Move flat_buffer and api_signature into front_end. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move flat_buffer and api_signature into front_end. I will need to use these in front_end to store precomputed information and computing combined signatures. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/02cb71685e9ce1ea96bb7865f2109b81774b7f60

Patch Set 1 #

Patch Set 2 : Update summary format generator. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1677 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +1 line, -1 line 0 comments Download
D pkg/analyzer/lib/src/summary/api_signature.dart View 1 chunk +0 lines, -153 lines 0 comments Download
M pkg/analyzer/lib/src/summary/fasta/model.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/analyzer/lib/src/summary/flat_buffers.dart View 1 chunk +0 lines, -957 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 1 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View 1 Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/analyzer/test/src/summary/api_signature_test.dart View 1 chunk +0 lines, -112 lines 0 comments Download
D pkg/analyzer/test/src/summary/flat_buffers_test.dart View 1 chunk +0 lines, -429 lines 0 comments Download
M pkg/analyzer/test/src/summary/test_all.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 1 1 chunk +5 lines, -3 lines 0 comments Download
A + pkg/front_end/lib/src/base/api_signature.dart View 1 chunk +0 lines, -2 lines 0 comments Download
A + pkg/front_end/lib/src/base/flat_buffers.dart View 1 chunk +0 lines, -2 lines 0 comments Download
A + pkg/front_end/test/src/base/api_signature_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
A + pkg/front_end/test/src/base/flat_buffers_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
A pkg/front_end/test/src/base/test_all.dart View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 7 months ago (2017-05-12 16:08:35 UTC) #1
Paul Berry
lgtm
3 years, 7 months ago (2017-05-12 17:34:16 UTC) #2
scheglov
3 years, 7 months ago (2017-05-12 17:48:35 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
02cb71685e9ce1ea96bb7865f2109b81774b7f60 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698