Chromium Code Reviews Chromium Code Reviews
Issue 2875263002:
📷 Add toggling zoom and test title to RenderTest results. (Closed)
| Index: build/android/pylib/instrumentation/render_test.html.jinja |
| diff --git a/build/android/pylib/instrumentation/render_test.html.jinja b/build/android/pylib/instrumentation/render_test.html.jinja |
| index ab84eb4f4ddb52f2d086003cd159c03a93ad6990..d91cf95ec7e6445027de92512f4c50c2c4fd6125 100644 |
| --- a/build/android/pylib/instrumentation/render_test.html.jinja |
| +++ b/build/android/pylib/instrumentation/render_test.html.jinja |
| @@ -1,14 +1,30 @@ |
| <html> |
| +<head> |
| + <title>{{ test_name }}</title> |
| + <script> |
| + function toggleZoom() { |
| + for (const img of document.getElementsByTagName("img")) { |
| + if (imgs[i].hasAttribute('style')) { |
|
Bernhard Bauer
2017/05/12 14:15:21
That should be |img| now, shouldn't it?
PEConn
2017/05/12 14:18:01
Ah yes, sorry - I had it right on my test page :-S
|
| + imgs[i].removeAttribute('style'); |
| + } else { |
| + imgs[i].style.width = '100%'; |
| + } |
| + } |
| + } |
| + </script> |
| +</head> |
| +<body> |
| <table> |
| <tr> |
| <th>Failure</th> |
| <th>Golden</th> |
| <th>Diff</th> |
| </tr> |
| - <tr> |
| - <td><img src="{{ failure_link }}" width="100%"/></td> |
| - <td><img src="{{ golden_link }}" width="100%"/></td> |
| - <td><img src="{{ diff_link }}" width="100%"/></td> |
| + <tr onclick="toggleZoom()"> |
| + <td><img src="{{ failure_link }}" style="width: 100%" /></td> |
| + <td><img src="{{ golden_link }}" style="width: 100%" /></td> |
| + <td><img src="{{ diff_link }}" style="width: 100%" /></td> |
| </tr> |
| </table> |
| +</body> |
| </html> |
