Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2875223003: convert completion tests to use new analysis driver (Closed)

Created:
3 years, 7 months ago by danrubel
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

convert completion tests to use new analysis driver Update more tests and remove dead code from tests R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/69cc6c318371b586f1dba3d1bf501906b274eda8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+537 lines, -623 lines) Patch
M pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart View 2 chunks +0 lines, -10 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart View 5 chunks +2 lines, -35 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/named_constructor_contributor_test.dart View 2 chunks +2 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/optype_test.dart View 9 chunks +533 lines, -570 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 7 months ago (2017-05-12 01:08:42 UTC) #2
Brian Wilkerson
lgtm!
3 years, 7 months ago (2017-05-12 13:13:10 UTC) #3
danrubel
3 years, 7 months ago (2017-05-12 18:48:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
69cc6c318371b586f1dba3d1bf501906b274eda8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698