Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: tools/testing/dart/summary_report.dart

Issue 2875203005: Refactor and clean up the status file parsing code. (Closed)
Patch Set: Dartfmt. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/status_file_parser.dart ('k') | tools/testing/dart/test_progress.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/summary_report.dart
diff --git a/tools/testing/dart/summary_report.dart b/tools/testing/dart/summary_report.dart
index e62f7726634aaf17a2b3cc822c777649cac2b701..0667c73773e15b8fe2fba8ffe95d815c6d4ffac5 100644
--- a/tools/testing/dart/summary_report.dart
+++ b/tools/testing/dart/summary_report.dart
@@ -4,7 +4,7 @@
library summary_report;
-import "status_file_parser.dart";
+import "expectation.dart";
import "test_runner.dart";
final summaryReport = new SummaryReport();
@@ -34,16 +34,15 @@ class SummaryReport {
var expectations = testCase.expectedOutcomes;
bool containsFail = expectations
- .any((expectation) => expectation.canBeOutcomeOf(Expectation.FAIL));
- bool containsPass = expectations.contains(Expectation.PASS);
+ .any((expectation) => expectation.canBeOutcomeOf(Expectation.fail));
+ bool containsPass = expectations.contains(Expectation.pass);
bool containsSkip = expectations
- .any((expectation) => expectation.canBeOutcomeOf(Expectation.SKIP));
- bool containsSkipByDesign =
- expectations.contains(Expectation.SKIP_BY_DESIGN);
- bool containsCrash = expectations.contains(Expectation.CRASH);
- bool containsOK = expectations.contains(Expectation.OK);
- bool containsSlow = expectations.contains(Expectation.SLOW);
- bool containsTimeout = expectations.contains(Expectation.TIMEOUT);
+ .any((expectation) => expectation.canBeOutcomeOf(Expectation.skip));
+ bool containsSkipByDesign = expectations.contains(Expectation.skipByDesign);
+ bool containsCrash = expectations.contains(Expectation.crash);
+ bool containsOK = expectations.contains(Expectation.ok);
+ bool containsSlow = expectations.contains(Expectation.slow);
+ bool containsTimeout = expectations.contains(Expectation.timeout);
++_total;
if (containsSkip) {
« no previous file with comments | « tools/testing/dart/status_file_parser.dart ('k') | tools/testing/dart/test_progress.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698