Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 2875183002: Better type for _match argument in AttributeMatch (Closed)

Created:
3 years, 7 months ago by sra1
Modified:
3 years, 7 months ago
Reviewers:
terry, Jacob
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Better type for _match argument in AttributeMatch This fixes two warnings in analyze_api_test: R=jacobr@google.com sdk/lib/html/dart2js/html_dart2js.dart:41478:31: Warning: The getter '_namespaceUri' is not defined for the class 'Node'. bool _matches(Node node) => node._namespaceUri == null; ^^^^^^^^^^^^^^^^^^ sdk/lib/html/dart2js/html_dart2js.dart:41514:31: Warning: The getter '_namespaceUri' is not defined for the class 'Node'. bool _matches(Node node) => node._namespaceUri == _namespace; ^^^^^^^^^^^^^^^^^^ Committed: https://github.com/dart-lang/sdk/commit/91f9ce3f71d55c4206f128dc8527e073d873b1d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M tools/dom/src/AttributeMap.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sra1
3 years, 7 months ago (2017-05-11 22:37:42 UTC) #2
Jacob
Dartium changes look safe. I'd test them using the buildbot. lgtm
3 years, 7 months ago (2017-05-11 23:43:56 UTC) #5
sra1
3 years, 7 months ago (2017-05-11 23:59:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
91f9ce3f71d55c4206f128dc8527e073d873b1d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698