Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/android/purge_ashmem/purge_ashmem.gyp

Issue 287513002: [Android] Build android tools as PIE and add a wrapper for ICS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nits + update binaries for telemetry Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/pylib/android_commands.py ('K') | « tools/android/ps_ext/ps_ext.gyp ('k') | tools/android/run_pie/run_pie.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/android/purge_ashmem/purge_ashmem.gyp
diff --git a/tools/android/purge_ashmem/purge_ashmem.gyp b/tools/android/purge_ashmem/purge_ashmem.gyp
index 842d7561bb3153239dc17397801e7db5418eb0c0..d563b1fa982783e7f34ae8c498c461a7fdae0919 100644
--- a/tools/android/purge_ashmem/purge_ashmem.gyp
+++ b/tools/android/purge_ashmem/purge_ashmem.gyp
@@ -13,19 +13,6 @@
'include_dirs': [
'../../../',
],
- 'conditions': [
- # Warning: A PIE tool cannot run on ICS 4.0.4, so only
- # build it as position-independent when ASAN
- # is activated. See b/6587214 for details.
- [ 'asan==1', {
- 'cflags': [
- '-fPIE',
- ],
- 'ldflags': [
- '-pie',
- ],
- }],
- ],
'sources': [
'purge_ashmem.c',
],
« build/android/pylib/android_commands.py ('K') | « tools/android/ps_ext/ps_ext.gyp ('k') | tools/android/run_pie/run_pie.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698