Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/android/forwarder2/forwarder.gyp

Issue 287513002: [Android] Build android tools as PIE and add a wrapper for ICS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nits + update binaries for telemetry Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/pylib/android_commands.py ('K') | « tools/android/file_poller/file_poller.gyp ('k') | tools/android/memdump/memdump.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/android/forwarder2/forwarder.gyp
diff --git a/tools/android/forwarder2/forwarder.gyp b/tools/android/forwarder2/forwarder.gyp
index 03496a64a137295432d5b243da2f5299f3d6b40e..fbf5eba6f2f0ebdf3825a467e29a3ce806893be1 100644
--- a/tools/android/forwarder2/forwarder.gyp
+++ b/tools/android/forwarder2/forwarder.gyp
@@ -30,19 +30,6 @@
'include_dirs': [
'../../..',
],
- 'conditions': [
- # Warning: A PIE tool cannot run on ICS 4.0.4, so only
- # build it as position-independent when ASAN
- # is activated. See b/6587214 for details.
- [ 'asan==1', {
- 'cflags': [
- '-fPIE',
- ],
- 'ldflags': [
- '-pie',
- ],
- }],
- ],
'sources': [
'command.cc',
'common.cc',
« build/android/pylib/android_commands.py ('K') | « tools/android/file_poller/file_poller.gyp ('k') | tools/android/memdump/memdump.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698