Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/telemetry/telemetry/core/backends/adb_commands.py

Issue 287513002: [Android] Build android tools as PIE and add a wrapper for ICS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/android/run_pie/run_pie.gyp ('K') | « tools/telemetry/bin/android/run_pie.sha1 ('k') | tools/telemetry/telemetry/core/platform/android_platform_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/adb_commands.py
diff --git a/tools/telemetry/telemetry/core/backends/adb_commands.py b/tools/telemetry/telemetry/core/backends/adb_commands.py
index d9b64a5ee2868e8ac03487ad934988b86f733169..7aea3681af78f58b3803179b16ee907b90e872c7 100644
--- a/tools/telemetry/telemetry/core/backends/adb_commands.py
+++ b/tools/telemetry/telemetry/core/backends/adb_commands.py
@@ -113,6 +113,7 @@ def SetupPrebuiltTools(adb):
'forwarder_dist/device_forwarder',
'md5sum_dist/md5sum_bin',
'purge_ashmem',
+ 'run_pie',
]
host_tools = [
@@ -141,7 +142,7 @@ def SetupPrebuiltTools(adb):
platform_name = ('android' if t in device_tools else
factory.GetPlatformBackendForCurrentOS().GetOSName())
prebuilt_path = support_binaries.FindPath(executable, platform_name)
- if not os.path.exists(prebuilt_path):
+ if not prebuilt_path or not os.path.exists(prebuilt_path):
raise NotImplementedError("""
%s must be checked into cloud storage.
Instructions:
« tools/android/run_pie/run_pie.gyp ('K') | « tools/telemetry/bin/android/run_pie.sha1 ('k') | tools/telemetry/telemetry/core/platform/android_platform_backend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698