Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/android/memdump/memdump.gyp

Issue 287513002: [Android] Build android tools as PIE and add a wrapper for ICS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/pylib/android_commands.py ('K') | « tools/android/forwarder2/forwarder.gyp ('k') | tools/android/ps_ext/ps_ext.gyp » ('j') | tools/android/run_pie/run_pie.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/android/memdump/memdump.gyp
diff --git a/tools/android/memdump/memdump.gyp b/tools/android/memdump/memdump.gyp
index 24ad1ecd34854659a2f6f2b83aca45fd0dc7ba55..f47cedf0048ddc50ddf969d4dde43b2087fd4e9a 100644
--- a/tools/android/memdump/memdump.gyp
+++ b/tools/android/memdump/memdump.gyp
@@ -10,19 +10,6 @@
'dependencies': [
'../../../base/base.gyp:base',
],
- 'conditions': [
- # Warning: A PIE tool cannot run on ICS 4.0.4, so only
- # build it as position-independent when ASAN
- # is activated. See b/6587214 for details.
- [ 'asan==1', {
- 'cflags': [
- '-fPIE',
- ],
- 'ldflags': [
- '-pie',
- ],
- }],
- ],
'sources': [
'memdump.cc',
],
« build/android/pylib/android_commands.py ('K') | « tools/android/forwarder2/forwarder.gyp ('k') | tools/android/ps_ext/ps_ext.gyp » ('j') | tools/android/run_pie/run_pie.c » ('J')

Powered by Google App Engine
This is Rietveld 408576698