build/android/provision_devices.py - Issue 287513002: [Android] Build android tools as PIE and add a wrapper for ICS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/provision_devices.py

Issue 287513002: [Android] Build android tools as PIE and add a wrapper for ICS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/provision_devices.py

diff --git a/build/android/provision_devices.py b/build/android/provision_devices.py

index 83c02a2a607a3fb75aed1c0258ac59571e9491bb..0549e81adbd17ad9c818e434919f9e4ba62564b9 100755

--- a/build/android/provision_devices.py

+++ b/build/android/provision_devices.py

@@ -64,10 +64,8 @@ def PushAndLaunchAdbReboot(devices, target):

device.old_interface.PushIfNeeded(adb_reboot, '/data/local/tmp/')

# Launch adb_reboot

print ' Launching adb_reboot ...'

- # TODO(jbudorick) Try to convert this to RunShellCommand.

bulach 2014/05/14 12:57:05 hmm... looks like there was some problems with Run

- p = subprocess.Popen(['adb', '-s', device_serial, 'shell'],

- stdin=subprocess.PIPE)

- p.communicate('/data/local/tmp/adb_reboot; exit\n')

+ device.old_interface.GetAndroidToolStatusAndOutput(

+ '/data/local/tmp/adb_reboot')

LaunchHostHeartbeat()