Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2875103002: Exclude function name from function type annotations in front end type inference tests. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Exclude function name from function type annotations in front end type inference tests. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/0c64db009a4f219022213a0f0c1e31a3afe4d09a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -43 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 3 chunks +0 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_downwards_incompatible_with_upwards_inference.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_downwards_incompatible_with_upwards_inference_top_level.dart View 1 chunk +5 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/block_bodied_lambdas_downwards_incompatible_with_upwards_inference_top_level.dart.strong.expect View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_function_of_t_using_the_t.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_list_literals_infer_if_value_types_match_context.dart View 3 chunks +18 lines, -18 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_functions_return_typedef.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_extract_method_tear_off.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_extract_method_tear_off_via_interface.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_from_top_level_executable_tear_off.dart View 1 chunk +5 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/inferred_type_from_top_level_executable_tear_off.dart.strong.expect View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_is_typedef.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_is_typedef_parameterized.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/static_method_tear_off.dart View 1 chunk +5 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/static_method_tear_off.dart.strong.expect View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_in_list_typed.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_in_map_typed.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-11 16:11:14 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-11 17:01:10 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-11 17:18:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c64db009a4f219022213a0f0c1e31a3afe4d09a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698