Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2875063003: Fix bugs supporting configuring DDC runtime settings before the application starts. (Closed)

Created:
3 years, 7 months ago by Jacob
Modified:
3 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bugs supporting configuring DDC runtime settings before the application starts. I don't see a better way to implement this given how DDC lazily initializes fields. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/ff588405fe4c38853d423f610884b8c5e147fc83

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -24 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart View 1 2 chunks +12 lines, -6 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/profile.dart View 1 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart View 1 1 chunk +11 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jacob
3 years, 7 months ago (2017-05-11 21:43:07 UTC) #2
vsm
lgtm https://codereview.chromium.org/2875063003/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart (right): https://codereview.chromium.org/2875063003/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart#newcode8 pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart:8: bool get _trapRuntimeErrors => JS('bool', 'dart.__trapRuntimeErrors'); Can you ...
3 years, 7 months ago (2017-05-11 21:45:56 UTC) #3
Jacob
On 2017/05/11 21:45:56, vsm wrote: > lgtm > > https://codereview.chromium.org/2875063003/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart > File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart (right): > ...
3 years, 7 months ago (2017-05-12 22:58:56 UTC) #4
Jacob
3 years, 7 months ago (2017-05-12 22:59:17 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:10001) manually as
ff588405fe4c38853d423f610884b8c5e147fc83 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698