Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/task_kill.py

Issue 2875043002: Suppress failures from taskkill when killing content_shell on Windows. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/task_kill.py
diff --git a/tools/task_kill.py b/tools/task_kill.py
index 247caaba4fc1a01aa6e60a4b3fd8be78e1711850..3ccf1c75f4eb357dcf0f53217bf89c5c57ee3e2e 100755
--- a/tools/task_kill.py
+++ b/tools/task_kill.py
@@ -215,7 +215,12 @@ def KillBrowsers():
status += Kill('chrome_helper')
status += Kill('iexplore')
status += Kill('safari')
- status += Kill('content_shell')
+ if os_name == "win32":
+ # TODO(29599): Let content_shell affect exit code on windows,
+ # once issue with zombie renderers is fixed.
+ Kill('content_shell')
+ else:
+ status += Kill('content_shell')
return status
def KillVCSystems():
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698