Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: components/subresource_filter/core/browser/subresource_filter_features.h

Issue 2875033004: [subresource_filter] Add debugging trace events around activation (Closed)
Patch Set: quick fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/core/browser/subresource_filter_features.h
diff --git a/components/subresource_filter/core/browser/subresource_filter_features.h b/components/subresource_filter/core/browser/subresource_filter_features.h
index e075356c3c22d1ee67528b60f1d3e86020025b51..a828a4ef7786ea075da03808044ddac89c2de442 100644
--- a/components/subresource_filter/core/browser/subresource_filter_features.h
+++ b/components/subresource_filter/core/browser/subresource_filter_features.h
@@ -5,7 +5,7 @@
#ifndef COMPONENTS_SUBRESOURCE_FILTER_CORE_BROWSER_SUBRESOURCE_FILTER_FEATURES_H_
#define COMPONENTS_SUBRESOURCE_FILTER_CORE_BROWSER_SUBRESOURCE_FILTER_FEATURES_H_
-#include <iosfwd>
+#include <memory>
#include <vector>
#include "base/feature_list.h"
@@ -16,6 +16,12 @@
#include "components/subresource_filter/core/common/activation_list.h"
#include "components/subresource_filter/core/common/activation_scope.h"
+namespace base {
+namespace trace_event {
+class TracedValue;
+} // namespace trace_event
+} // namespace base
+
namespace subresource_filter {
// Encapsulates a set of parameters that define how the subresource filter
@@ -102,6 +108,8 @@ struct Configuration {
bool operator==(const Configuration& rhs) const;
bool operator!=(const Configuration& rhs) const;
+ std::unique_ptr<base::trace_event::TracedValue> ToTracedValue() const;
+
// Factory methods for preset configurations.
//
// To add a new preset:
@@ -117,9 +125,6 @@ struct Configuration {
GeneralSettings general_settings;
};
-// For logging in tests.
-std::ostream& operator<<(std::ostream& os, const Configuration& config);
-
// Thread-safe, ref-counted wrapper around an immutable list of configurations.
class ConfigurationList : public base::RefCountedThreadSafe<ConfigurationList> {
public:

Powered by Google App Engine
This is Rietveld 408576698