[subresource_filter] Add debugging trace events around activation

components/subresource_filter/core/browser/subresource_filter_features.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SUBRESOURCE_FILTER_CORE_BROWSER_SUBRESOURCE_FILTER_FEATURES_H_
 #define COMPONENTS_SUBRESOURCE_FILTER_CORE_BROWSER_SUBRESOURCE_FILTER_FEATURES_H_
 
 #include <iosfwd>
+#include <memory>
 #include <vector>
 
 #include "base/feature_list.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/strings/string_piece.h"
 #include "components/subresource_filter/core/common/activation_level.h"
 #include "components/subresource_filter/core/common/activation_list.h"
 #include "components/subresource_filter/core/common/activation_scope.h"
 
+namespace base {
+namespace trace_event {
+class TracedValue;
+}  // namespace trace_event
+}  // namespace base
+
 namespace subresource_filter {
 
 // Encapsulates a set of parameters that define how the subresource filter
 // feature should operate. Each configuration consists of three parts as
 // described in detail below.
 //
 // There can be multiple configuration enabled at the same time. For each
 // navigation, however, subresource filtering will be activated according to
 // exactly one of these enabled configuration, if any. Namely, the configuration
 // with the highest |priority| among those whose |activation_conditions| are
@@ skipping 66 matching lines @@
                 ActivationList activation_list = ActivationList::NONE);
   Configuration(const Configuration&);
   Configuration(Configuration&&);
   ~Configuration();
   Configuration& operator=(const Configuration&);
   Configuration& operator=(Configuration&&);
 
   bool operator==(const Configuration& rhs) const;
   bool operator!=(const Configuration& rhs) const;
 
+  std::unique_ptr<base::trace_event::TracedValue> GetTracedValue() const;

[engedy, 2017/05/15 12:10:38]

nit: {As|To}TracedValue

[Charlie Harrison, 2017/05/15 15:14:22]

Renamed ToTracedValue.

+
   // Factory methods for preset configurations.
   //
   // To add a new preset:
   //  1.) Define a named factory method here.
   //  2.) Define a name for the configuration to be used in variation params.
   //  3.) Register it into |kAvailablePresetConfigurations| in the .cc file.
   //  4.) Update unittests to cover the new preset.
   static Configuration MakePresetForLiveRunOnPhishingSites();
   static Configuration MakePresetForPerformanceTestingDryRunOnAllSites();
 
@@ skipping 84 matching lines @@
 extern const char kRulesetFlavorParameterName[];
 
 extern const char kEnablePresetsParameterName[];
 extern const char kDisablePresetsParameterName[];
 extern const char kPresetLiveRunOnPhishingSites[];
 extern const char kPresetPerformanceTestingDryRunOnAllSites[];
 
 }  // namespace subresource_filter
 
 #endif  // COMPONENTS_SUBRESOURCE_FILTER_CORE_BROWSER_SUBRESOURCE_FILTER_FEATURES_H_