Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2875023002: Add test for initialization of instance fields with initializer expressions (Closed)

Created:
3 years, 7 months ago by zhivkag
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add test for initialization of instance fields with initializer expressions BUG= R=dmitryas@google.com, kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/a9ce0c53f70da9a5ce8544aee1aaeee8ef58d297

Patch Set 1 #

Patch Set 2 : Add test with field initializer and redirecting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -0 lines) Patch
A pkg/kernel/testcases/interpreter/object_fields_test.dart View 1 1 chunk +49 lines, -0 lines 0 comments Download
A pkg/kernel/testcases/interpreter/object_fields_test.dart.expect View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zhivkag
3 years, 7 months ago (2017-05-11 10:49:07 UTC) #2
Kevin Millikin (Google)
LGTM
3 years, 7 months ago (2017-05-11 11:33:16 UTC) #3
Dmitry Stefantsov
LGTM
3 years, 7 months ago (2017-05-11 11:33:16 UTC) #4
zhivkag
3 years, 7 months ago (2017-05-11 12:00:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a9ce0c53f70da9a5ce8544aee1aaeee8ef58d297 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698