Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2874973004: [kernel] Add support for cloning Vector nodes and ClosureCreation (Closed)

Created:
3 years, 7 months ago by jensj
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[kernel] Add support for cloning Vector nodes and ClosureCreation This adds support for cloning the following kernel AST nodes. * ClosureCreation * VectorCreation * VectorSet * VectorGet * VectorCopy This will be needed for kernel closure conversion. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/b095347421e33df8ed93926bf61a62151ba65225

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M pkg/kernel/lib/clone.dart View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jensj
3 years, 7 months ago (2017-05-11 09:22:27 UTC) #2
Kevin Millikin (Google)
lgtm
3 years, 7 months ago (2017-05-11 09:31:59 UTC) #3
jensj
3 years, 7 months ago (2017-05-11 09:33:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b095347421e33df8ed93926bf61a62151ba65225 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698