Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: net/cookies/cookie_monster.h

Issue 2874973002: Flush Channel IDs when Cookies get saved to a persistent backend (Closed)
Patch Set: clean up a few things Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cookies/cookie_monster.h
diff --git a/net/cookies/cookie_monster.h b/net/cookies/cookie_monster.h
index ff7c47f8b0a419348981c886ed2da9414d46ad0e..18b966ff6f2e54b75a91492dda4b2939f0534308 100644
--- a/net/cookies/cookie_monster.h
+++ b/net/cookies/cookie_monster.h
@@ -38,6 +38,7 @@ class HistogramBase;
namespace net {
+class ChannelIDService;
class CookieMonsterDelegate;
// The cookie monster is the system for storing and retrieving cookies. It has
@@ -134,6 +135,12 @@ class NET_EXPORT CookieMonster : public CookieStore {
// creation/deletion of cookies.
CookieMonster(PersistentCookieStore* store, CookieMonsterDelegate* delegate);
+ // Like above, but includes a non-owning pointer |channel_id_service| for the
+ // corresponding ChannelIDService used with this CookieStore.
mattm 2017/05/12 00:02:47 add note about |channel_id_service| lifetime
nharper 2017/05/12 02:47:23 Done.
+ CookieMonster(PersistentCookieStore* store,
+ CookieMonsterDelegate* delegate,
+ ChannelIDService* channel_id_service);
+
// Only used during unit testing.
CookieMonster(PersistentCookieStore* store,
CookieMonsterDelegate* delegate,
@@ -217,6 +224,11 @@ class NET_EXPORT CookieMonster : public CookieStore {
bool IsEphemeral() override;
private:
+ CookieMonster(PersistentCookieStore* store,
+ CookieMonsterDelegate* delegate,
+ ChannelIDService* channel_id_service,
+ base::TimeDelta last_access_threshold);
+
// For queueing the cookie monster calls.
class CookieMonsterTask;
template <typename Result>
@@ -716,6 +728,7 @@ class NET_EXPORT CookieMonster : public CookieStore {
std::vector<std::string> cookieable_schemes_;
scoped_refptr<CookieMonsterDelegate> delegate_;
+ ChannelIDService* channel_id_service_;
base::Time last_statistic_record_time_;

Powered by Google App Engine
This is Rietveld 408576698