Flush Channel IDs when Cookies get saved to a persistent backend

net/cookies/cookie_monster_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cookies/cookie_monster.h"
 
 #include <algorithm>
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 15 matching lines @@
 #include "base/test/mock_callback.h"
 #include "base/threading/thread.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "base/time/time.h"
 #include "net/cookies/canonical_cookie.h"
 #include "net/cookies/cookie_constants.h"
 #include "net/cookies/cookie_monster_store_test.h"  // For CookieStore mock
 #include "net/cookies/cookie_store_unittest.h"
 #include "net/cookies/cookie_util.h"
 #include "net/cookies/parsed_cookie.h"
+#include "net/ssl/channel_id_service.h"
+#include "net/ssl/default_channel_id_store.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace net {
 
 using CookiePredicate = CookieStore::CookiePredicate;
 using base::Time;
 using base::TimeDelta;
 
@@ skipping 2416 matching lines @@
 
   int callback_count() { return callback_count_; }
 
  private:
   friend class base::RefCountedThreadSafe<CallbackCounter>;
   ~CallbackCounter() {}
 
   volatile int callback_count_;
 };
 
+class FlushCountingChannelIDStore : public DefaultChannelIDStore {
+ public:
+  FlushCountingChannelIDStore()
+      : DefaultChannelIDStore(nullptr), flush_count_(0) {}
+
+  void Flush() override { flush_count_++; }
+
+  int flush_count() { return flush_count_; }
+
+ private:
+  int flush_count_;
+};
+
 }  // namespace
 
 // Test that FlushStore() is forwarded to the store and callbacks are posted.
 TEST_F(CookieMonsterTest, FlushStore) {
   scoped_refptr<CallbackCounter> counter(new CallbackCounter());
   scoped_refptr<FlushablePersistentStore> store(new FlushablePersistentStore());
   std::unique_ptr<CookieMonster> cm(new CookieMonster(store.get(), nullptr));
 
   ASSERT_EQ(0, store->flush_count());
   ASSERT_EQ(0, counter->callback_count());
@@ skipping 34 matching lines @@
   base::RunLoop().RunUntilIdle();
 
   ASSERT_EQ(2, counter->callback_count());
 
   cm->FlushStore(base::Bind(&CallbackCounter::Callback, counter));
   base::RunLoop().RunUntilIdle();
 
   ASSERT_EQ(3, counter->callback_count());
 }
 
+TEST_F(CookieMonsterTest, FlushChannelIDs) {
+  // |channel_id_service| owns |channel_id_store|.
+  FlushCountingChannelIDStore* channel_id_store =
+      new FlushCountingChannelIDStore();
+  std::unique_ptr<ChannelIDService> channel_id_service(
+      new ChannelIDService(channel_id_store));
+
+  scoped_refptr<FlushablePersistentStore> store(new FlushablePersistentStore());
+  std::unique_ptr<CookieMonster> cm(
+      new CookieMonster(store.get(), nullptr, channel_id_service.get()));
+  EXPECT_EQ(0, channel_id_store->flush_count());
+
+  // Before initialization, FlushStore() doesn't propagate to the
+  // ChannelIDStore.
+  cm->FlushStore(base::Closure());
+  base::RunLoop().RunUntilIdle();
+
+  EXPECT_EQ(0, channel_id_store->flush_count());
+
+  // After initialization, FlushStore() propagates to the ChannelIDStore.
+  GetAllCookies(cm.get());  // Force init.
+  cm->FlushStore(base::Closure());
+  base::RunLoop().RunUntilIdle();
+
+  EXPECT_EQ(1, channel_id_store->flush_count());
+
+  // If there is no persistent store, then a ChannelIDStore won't be notified.
+  cm.reset(new CookieMonster(nullptr, nullptr, channel_id_service.get()));
+  GetAllCookies(cm.get());  // Force init.
+  cm->FlushStore(base::Closure());
+  base::RunLoop().RunUntilIdle();
+
+  EXPECT_EQ(1, channel_id_store->flush_count());
+}
+
 TEST_F(CookieMonsterTest, SetAllCookies) {
   scoped_refptr<FlushablePersistentStore> store(new FlushablePersistentStore());
   std::unique_ptr<CookieMonster> cm(new CookieMonster(store.get(), nullptr));
   cm->SetPersistSessionCookies(true);
 
   EXPECT_TRUE(SetCookie(cm.get(), http_www_google_.url(), "U=V; path=/"));
   EXPECT_TRUE(SetCookie(cm.get(), http_www_google_.url(), "W=X; path=/foo"));
   EXPECT_TRUE(SetCookie(cm.get(), http_www_google_.url(), "Y=Z; path=/"));
 
   CookieList list;
@@ skipping 835 matching lines @@
       monster()->AddCallbackForCookie(
           test_url_, "abc",
           base::Bind(&RecordCookieChanges, &cookies1, nullptr)));
   SetCookie(monster(), test_url_, "abc=def");
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(1U, cookies0.size());
   EXPECT_EQ(1U, cookies0.size());
 }
 
 }  // namespace net