Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: ash/test/ash_test_helper.cc

Issue 2874963002: chromeos: wireup more display management for mushrome (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/test/ash_test_helper.cc
diff --git a/ash/test/ash_test_helper.cc b/ash/test/ash_test_helper.cc
index d6911f5c0e3043e15420f3ca5e904ca61e74bf12..558537b5f4d0c903c16d49f804fd90ca665ecfcc 100644
--- a/ash/test/ash_test_helper.cc
+++ b/ash/test/ash_test_helper.cc
@@ -178,7 +178,8 @@ void AshTestHelper::SetUp(bool start_session) {
if (start_session)
session_controller_client_->CreatePredefinedUserSessions(1);
- if (config_ == Config::CLASSIC) {
+ // TODO(sky): mash should use this too http://crbug.com/718860.
+ if (config_ != Config::MASH) {
// ScreenLayoutObserver is specific to classic-ash.
msw 2017/05/11 01:07:17 nit: update comment, ditto below (line 189)
sky 2017/05/11 14:06:53 Done.
// Tests that change the display configuration generally don't care about
// the notifications and the popup UI can interfere with things like
@@ -191,7 +192,9 @@ void AshTestHelper::SetUp(bool start_session) {
DisplayConfigurationControllerTestApi(
shell->display_configuration_controller())
.DisableDisplayAnimator();
+ }
+ if (config_ == Config::CLASSIC) {
// TODO: disabled for mash as AcceleratorControllerDelegateAura isn't
// created in mash http://crbug.com/632111.
test_screenshot_delegate_ = new TestScreenshotDelegate();

Powered by Google App Engine
This is Rietveld 408576698