Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: components/autofill/core/common/autofill_util.h

Issue 2874933008: Adds animation as feature variation to keyboard accessory. (Closed)
Patch Set: Switch to base/metrics/field_trial_params.h API from variations:: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/autofill_util.h
diff --git a/components/autofill/core/common/autofill_util.h b/components/autofill/core/common/autofill_util.h
index a9738774580de048b909e43a5b407ab884dbc025..6a67f3ef8704ff75be3fe2617000abbd6e7cf3ef 100644
--- a/components/autofill/core/common/autofill_util.h
+++ b/components/autofill/core/common/autofill_util.h
@@ -13,8 +13,17 @@
#include "base/strings/string16.h"
#include "components/autofill/core/common/form_field_data.h"
+namespace base {
+struct Feature;
+}
+
namespace autofill {
+extern const base::Feature kAutofillKeyboardAccessory;
+extern const char kAutofillKeyboardAccessoryAnimationDurationKey[];
+extern const char kAutofillKeyboardAccessoryLimitLabelWidthKey[];
+extern const char kAutofillKeyboardAccessoryHintKey[];
+
// Returns true when command line switch |kEnableSuggestionsWithSubstringMatch|
// is on.
bool IsFeatureSubstringMatchEnabled();
@@ -25,6 +34,17 @@ bool IsShowAutofillSignaturesEnabled();
// Returns true when keyboard accessory is enabled.
bool IsKeyboardAccessoryEnabled();
+// Returns animation duration for keyboard accessory. If 0, we do not animate.
+unsigned int GetKeyboardAccessoryAnimationDuration();
+
+// Returns true if we must limit width of keyboard accessory suggestion label to
+// half of device's pixel width.
+bool ShouldLimitKeyboardAccessorySuggestionLabelWidth();
+
+// Returns true if we show a hint in the keyboard accessory suggestions to call
+// attention to the availability of autofill suggestions.
+bool IsHintEnabledInKeyboardAccessory();
+
// A token is a sequences of contiguous characters separated by any of the
// characters that are part of delimiter set {' ', '.', ',', '-', '_', '@'}.
« no previous file with comments | « components/autofill/core/common/autofill_switches.cc ('k') | components/autofill/core/common/autofill_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698