chrome/browser/ui/android/autofill/autofill_popup_view_android.cc - Issue 2874933008: Adds animation as feature variation to keyboard accessory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

Issue 2874933008: Adds animation as feature variation to keyboard accessory. (Closed)

Patch Set: Switch to base/metrics/field_trial_params.h API from variations:: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

diff --git a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

index 9eda253c35ce8175d657380f7e0aeae055a9d134..e81d68d2fd7e78e0f81d50085e436943510a1967 100644

--- a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

+++ b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

@@ -183,7 +183,9 @@ bool AutofillPopupViewAndroid::RegisterAutofillPopupViewAndroid(JNIEnv* env) {

AutofillPopupView* AutofillPopupView::Create(

AutofillPopupController* controller) {

if (IsKeyboardAccessoryEnabled())

- return new AutofillKeyboardAccessoryView(controller);

+ return new AutofillKeyboardAccessoryView(

+ controller, GetKeyboardAccessoryAnimationDuration(),

+ ShouldLimitKeyboardAccessorySuggestionLabelWidth());

return new AutofillPopupViewAndroid(controller);

}