Adds animation as feature variation to keyboard accessory.

components/autofill/core/browser/autofill_external_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_external_delegate.h"
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 65 matching lines @@
   should_show_cc_signin_promo_ =
       manager_->ShouldShowCreditCardSigninPromo(query_form_, query_field_);
 }
 
 void AutofillExternalDelegate::OnSuggestionsReturned(
     int query_id,
     const std::vector<Suggestion>& input_suggestions) {
   if (query_id != query_id_)
     return;
 
-  // The suggestions and warnings are "above the fold" and are separated from
-  // other menu items with a separator.
   std::vector<Suggestion> suggestions(input_suggestions);
+
   // Hide warnings as appropriate.
   PossiblyRemoveAutofillWarnings(&suggestions);
 
 #if !defined(OS_ANDROID)
   // If there are above the fold suggestions at this point, add a separator to
   // go between the values and menu items.
   if (!suggestions.empty()) {
     suggestions.push_back(Suggestion());
     suggestions.back().frontend_id = POPUP_ITEM_ID_SEPARATOR;
   }
@@ skipping 233 matching lines @@
   }
 }
 
 void AutofillExternalDelegate::ApplyAutofillOptions(
     std::vector<Suggestion>* suggestions) {
   // The form has been auto-filled, so give the user the chance to clear the
   // form.  Append the 'Clear form' menu item.
   if (query_field_.is_autofilled) {
     base::string16 value =
         l10n_util::GetStringUTF16(IDS_AUTOFILL_CLEAR_FORM_MENU_ITEM);
+#if defined(OS_ANDROID)
     if (IsKeyboardAccessoryEnabled())
       value = base::i18n::ToUpper(value);
+#endif
 
     suggestions->push_back(Suggestion(value));
     suggestions->back().frontend_id = POPUP_ITEM_ID_CLEAR_FORM;
   }
 
   // Append the 'Chrome Autofill options' menu item, or the menu item specified
-  // in the popup layout experiment.
+  // in the popup layout experiment. If we do not include
+  // |POPUP_ITEM_ID_CLEAR_FORM|, include a hint for keyboard accessory.
   suggestions->push_back(Suggestion(GetSettingsSuggestionValue()));
   suggestions->back().frontend_id = POPUP_ITEM_ID_AUTOFILL_OPTIONS;
-  if (IsKeyboardAccessoryEnabled())
+#if defined(OS_ANDROID)
+  if (IsKeyboardAccessoryEnabled()) {
     suggestions->back().icon = base::ASCIIToUTF16("settings");
+    if (IsHintEnabledInKeyboardAccessory() && !query_field_.is_autofilled) {
+      Suggestion create_icon;
+      create_icon.icon = base::ASCIIToUTF16("create");
+      create_icon.frontend_id = POPUP_ITEM_ID_CREATE_HINT;
+      suggestions->push_back(create_icon);
+    }
+  }
+#endif
 }
 
 void AutofillExternalDelegate::InsertDataListValues(
     std::vector<Suggestion>* suggestions) {
   if (data_list_values_.empty())
     return;
 
   // Go through the list of autocomplete values and remove them if they are in
   // the list of datalist values.
   std::set<base::string16> data_list_set(data_list_values_.begin(),
@@ skipping 30 matching lines @@
     const {
   if (IsKeyboardAccessoryEnabled()) {
     return l10n_util::GetStringUTF16(IDS_AUTOFILL_OPTIONS_CONTENT_DESCRIPTION);
   }
   return l10n_util::GetStringUTF16(is_credit_card_popup_ ?
                                    IDS_AUTOFILL_CREDIT_CARD_OPTIONS_POPUP :
                                    IDS_AUTOFILL_OPTIONS_POPUP);
 }
 
 }  // namespace autofill