Adds animation as feature variation to keyboard accessory.

chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "chrome/browser/android/resource_mapper.h"
 #include "chrome/browser/ui/android/view_android_helper.h"
@@ skipping 27 matching lines @@
   Java_AutofillKeyboardAccessoryBridge_addToAutofillSuggestionArray(
       env, data_array, position,
       base::android::ConvertUTF16ToJavaString(env, suggestion.value),
       base::android::ConvertUTF16ToJavaString(env, suggestion.label),
       android_icon_id, suggestion.frontend_id, deletable);
 }
 
 }  // namespace
 
 AutofillKeyboardAccessoryView::AutofillKeyboardAccessoryView(
-    AutofillPopupController* controller)
-    : controller_(controller), deleting_index_(-1) {
+    AutofillPopupController* controller,
+    unsigned int animation_duration_millis,
+    bool should_limit_label_width)
+    : controller_(controller),
+      animation_duration_millis_(animation_duration_millis),
+      should_limit_label_width_(should_limit_label_width),
+      deleting_index_(-1) {
   JNIEnv* env = base::android::AttachCurrentThread();
   java_object_.Reset(Java_AutofillKeyboardAccessoryBridge_create(env));
 }
 
 AutofillKeyboardAccessoryView::~AutofillKeyboardAccessoryView() {
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_AutofillKeyboardAccessoryBridge_resetNativeViewPointer(env,
                                                               java_object_);
 }
 
 void AutofillKeyboardAccessoryView::Show() {
   JNIEnv* env = base::android::AttachCurrentThread();
   ui::ViewAndroid* view_android = controller_->container_view();
   DCHECK(view_android);
   Java_AutofillKeyboardAccessoryBridge_init(
       env, java_object_, reinterpret_cast<intptr_t>(this),
-      view_android->GetWindowAndroid()->GetJavaObject());
+      view_android->GetWindowAndroid()->GetJavaObject(),
+      animation_duration_millis_, should_limit_label_width_);
 
   OnSuggestionsChanged();
 }
 
 void AutofillKeyboardAccessoryView::Hide() {
   controller_ = nullptr;
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_AutofillKeyboardAccessoryBridge_dismiss(env, java_object_);
 }
 
 void AutofillKeyboardAccessoryView::OnSelectedRowChanged(
     base::Optional<int> previous_row_selection,
     base::Optional<int> current_row_selection) {}
 
 void AutofillKeyboardAccessoryView::OnSuggestionsChanged() {
   JNIEnv* env = base::android::AttachCurrentThread();
   size_t count = controller_->GetLineCount();
   ScopedJavaLocalRef<jobjectArray> data_array =
       Java_AutofillKeyboardAccessoryBridge_createAutofillSuggestionArray(env,
                                                                          count);
   positions_.resize(count);
   size_t position = 0;
 
-  // Place "CLEAR FORM" item first in the list.
+  // Place "CLEAR FORM" and "CREATE HINT" items first in the list.
+  // Both "CLEAR FORM" and "CREATE HINT" cannot be present in the list.
   for (size_t i = 0; i < count; ++i) {
     const Suggestion& suggestion = controller_->GetSuggestionAt(i);
-    if (suggestion.frontend_id == POPUP_ITEM_ID_CLEAR_FORM) {
-      AddToJavaArray(suggestion, controller_->layout_model().GetIconResourceID(
-                                     suggestion.icon),
-                     env, data_array.obj(), position, false);
+    if (suggestion.frontend_id == POPUP_ITEM_ID_CLEAR_FORM ||
+        suggestion.frontend_id == POPUP_ITEM_ID_CREATE_HINT) {
+      AddToJavaArray(
+          suggestion,
+          controller_->layout_model().GetIconResourceID(suggestion.icon), env,
+          data_array.obj(), position, false);
       positions_[position++] = i;
     }
   }
 
+  DCHECK_LT(position, 2U);
+
   for (size_t i = 0; i < count; ++i) {
     const Suggestion& suggestion = controller_->GetSuggestionAt(i);
-    if (suggestion.frontend_id != POPUP_ITEM_ID_CLEAR_FORM) {
+    if (suggestion.frontend_id != POPUP_ITEM_ID_CLEAR_FORM &&
+        suggestion.frontend_id != POPUP_ITEM_ID_CREATE_HINT) {
       bool deletable =
           controller_->GetRemovalConfirmationText(i, nullptr, nullptr);
       AddToJavaArray(suggestion, controller_->layout_model().GetIconResourceID(
                                      suggestion.icon),
                      env, data_array.obj(), position, deletable);
       positions_[position++] = i;
     }
   }
 
   Java_AutofillKeyboardAccessoryBridge_show(env, java_object_, data_array,
@@ skipping 48 matching lines @@
   delete this;
 }
 
 // static
 bool AutofillKeyboardAccessoryView::RegisterAutofillKeyboardAccessoryView(
     JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace autofill