Adds animation as feature variation to keyboard accessory.

components/autofill/core/common/autofill_util.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/common/autofill_util.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
+#include "base/feature_list.h"
 #include "base/i18n/case_conversion.h"
 #include "base/metrics/field_trial.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "components/autofill/core/common/autofill_switches.h"
+#include "components/variations/variations_associated_data.h"
 
 namespace autofill {
 
+const base::Feature kAutofillKeyboardAccessory{
+    "AutofillKeyboardAccessory", base::FEATURE_DISABLED_BY_DEFAULT};
+const char kAutofillKeyboardAccessoryAnimationDurationKey[] =
+    "animation_duration_millis";
+const char kAutofillKeyboardAccessoryLimitLabelWidthKey[] =
+    "should_limit_label_width";
+const char kAutofillKeyboardAccessoryHintKey[] =
+    "is_hint_shown_before_suggestion";
+
 namespace {
 
 const char kSplitCharacters[] = " .,-_@";
 
 template <typename Char>
 struct Compare : base::CaseInsensitiveCompareASCII<Char> {
   explicit Compare(bool case_sensitive) : case_sensitive_(case_sensitive) {}
   bool operator()(Char x, Char y) const {
     return case_sensitive_ ? (x == y)
                            : base::CaseInsensitiveCompareASCII<Char>::
@@ skipping 11 matching lines @@
       switches::kEnableSuggestionsWithSubstringMatch);
 }
 
 bool IsShowAutofillSignaturesEnabled() {
   return base::CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kShowAutofillSignatures);
 }
 
 bool IsKeyboardAccessoryEnabled() {
 #if defined(OS_ANDROID)
-  return base::CommandLine::ForCurrentProcess()->HasSwitch(
-             switches::kEnableAccessorySuggestionView) ||
-         (base::FieldTrialList::FindFullName("AutofillKeyboardAccessory") ==
-              "Enabled" &&
-          !base::CommandLine::ForCurrentProcess()->HasSwitch(
-              switches::kDisableAccessorySuggestionView));
+  return base::FeatureList::IsEnabled(kAutofillKeyboardAccessory);
 #else  // !defined(OS_ANDROID)
   return false;
 #endif
 }
+
+unsigned int GetKeyboardAccessoryAnimationDuration() {
+#if defined(OS_ANDROID)
+  unsigned int value;
+  const std::string param_value = variations::GetVariationParamValueByFeature(

[Alexei Svitkine (slow), 2017/05/19 19:57:22]

Please use base/metrics/field_trial_params.h APIs instead.

Then, you don't need the variations DEPS change.

[csashi, 2017/05/19 20:41:22]

Done.

+      kAutofillKeyboardAccessory,
+      kAutofillKeyboardAccessoryAnimationDurationKey);
+  if (!param_value.empty() && base::StringToUint(param_value, &value))
+    return value;
+  return 0;
+#else  // !defined(OS_ANDROID)
+  NOTREACHED();
+  return 0;
+#endif
+}
+
+bool ShouldLimitKeyboardAccessorySuggestionLabelWidth() {
+#if defined(OS_ANDROID)
+  const std::string param_value = variations::GetVariationParamValueByFeature(
+      kAutofillKeyboardAccessory, kAutofillKeyboardAccessoryLimitLabelWidthKey);
+  return param_value == "true";
+#else  // !defined(OS_ANDROID)
+  NOTREACHED();
+  return false;
+#endif
+}
+
+bool IsHintEnabledInKeyboardAccessory() {
+#if defined(OS_ANDROID)
+  const std::string param_value = variations::GetVariationParamValueByFeature(
+      kAutofillKeyboardAccessory, kAutofillKeyboardAccessoryHintKey);
+  return param_value == "true";
+#else  // !defined(OS_ANDROID)
+  NOTREACHED();
+  return false;
+#endif
+}
 
 bool FieldIsSuggestionSubstringStartingOnTokenBoundary(
     const base::string16& suggestion,
     const base::string16& field_contents,
     bool case_sensitive) {
   if (!IsFeatureSubstringMatchEnabled()) {
     return base::StartsWith(suggestion, field_contents,
                             case_sensitive
                                 ? base::CompareCase::SENSITIVE
                                 : base::CompareCase::INSENSITIVE_ASCII);
@@ skipping 65 matching lines @@
 }
 
 std::vector<std::string> LowercaseAndTokenizeAttributeString(
     const std::string& attribute) {
   return base::SplitString(base::ToLowerASCII(attribute),
                            base::kWhitespaceASCII, base::TRIM_WHITESPACE,
                            base::SPLIT_WANT_NONEMPTY);
 }
 
 }  // namespace autofill