chrome/android/java/res/drawable/ic_create_googblue.xml - Issue 2874933008: Adds animation as feature variation to keyboard accessory.

Side by Side Diff: chrome/android/java/res/drawable/ic_create_googblue.xml

Issue 2874933008: Adds animation as feature variation to keyboard accessory. (Closed)

Patch Set: Postpone RTL animation with TODO until we understand expected behavior. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <vector xmlns:android="http://schemas.android.com/apk/res/android"
	Ted C 2017/05/17 00:04:29 Hmm..we already have two pencil icons in Chrome b Hmm..we already have two pencil icons in Chrome bookmark_edit_normal and bookmark_edit_active We should really just consolidate all of these into one. The gotcha is that it doesn't have the line underneath it, but I don't think we should introduce a new asset just for the line when we could reduce 3 into one and tint them. csashi 2017/05/17 01:14:15 How about I use bookmark_edit_normal? FWIW, bookma Show quoted text On 2017/05/17 00:04:29, Ted C wrote: > Hmm..we already have two pencil icons in Chrome > > bookmark_edit_normal and bookmark_edit_active > > We should really just consolidate all of these into one. The gotcha is that it > doesn't have the line underneath it, but I don't think we should introduce a new > asset just for the line when we could reduce 3 into one and tint them. How about I use bookmark_edit_normal? FWIW, bookmark_edit_normal is being used in chrome/android/java/res/layout/payment_option_edit_icon.xml. I don't know if the blue or the line underneath it is critical for the experiment. If you agree, I can remove this asset. Theresa 2017/05/17 15:13:46 Keeping bookmark_edit_normal sounds good to me. bo Show quoted text On 2017/05/17 01:14:15, csashi wrote: > On 2017/05/17 00:04:29, Ted C wrote: > > Hmm..we already have two pencil icons in Chrome > > > > bookmark_edit_normal and bookmark_edit_active > > > > We should really just consolidate all of these into one. The gotcha is that > it > > doesn't have the line underneath it, but I don't think we should introduce a > new > > asset just for the line when we could reduce 3 into one and tint them. > > How about I use bookmark_edit_normal? FWIW, bookmark_edit_normal is being used > in chrome/android/java/res/layout/payment_option_edit_icon.xml. I don't know if > the blue or the line underneath it is critical for the experiment. If you agree, > I can remove this asset. Keeping bookmark_edit_normal sounds good to me. bookmark_edit_active (only used in bookmarks) can be removed and tinted programatically (either as part of this change or I can handle it separately). Since bookmark_edit_normal hasn't been a bookmark-only asset for some time now, let's rename it to ic_edit_24dp so that it's easier for others to find. csashi 2017/05/17 18:38:53 Done. Show quoted text On 2017/05/17 15:13:46, Theresa wrote: > On 2017/05/17 01:14:15, csashi wrote: > > On 2017/05/17 00:04:29, Ted C wrote: > > > Hmm..we already have two pencil icons in Chrome > > > > > > bookmark_edit_normal and bookmark_edit_active > > > > > > We should really just consolidate all of these into one. The gotcha is that > > it > > > doesn't have the line underneath it, but I don't think we should introduce a > > new > > > asset just for the line when we could reduce 3 into one and tint them. > > > > How about I use bookmark_edit_normal? FWIW, bookmark_edit_normal is being used > > in chrome/android/java/res/layout/payment_option_edit_icon.xml. I don't know > if > > the blue or the line underneath it is critical for the experiment. If you > agree, > > I can remove this asset. > > Keeping bookmark_edit_normal sounds good to me. bookmark_edit_active (only used > in bookmarks) can be removed and tinted programatically (either as part of this > change or I can handle it separately). > > Since bookmark_edit_normal hasn't been a bookmark-only asset for some time now, > let's rename it to ic_edit_24dp so that it's easier for others to find. Done.
	7 xmlns:tools="http://schemas.android.com/tools"

	8 tools:targetApi="21"

	9 android:width="24dp"

	10 android:height="24dp"

	11 android:viewportWidth="24"

	12 android:viewportHeight="24">

	13

	14 <path

	15 android:fillColor="#4285F4"

	16 android:pathData=

	17 "M3 17.25V21h3.75L17.81 9.94l-3.75-3.75L3 17.25zM20.71 7.04c.39-.39 .39 -1.02

	18 0-1.41l-2.34-2.34c-.39-.39-1.02-.39-1.41 0l-1.83 1.83 3.75 3.75 1.83-1.83z" />

	19 <path

	20 android:pathData="M0 0h24v24H0z" />

	21 </vector>

OLD	NEW