third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h - Issue 2874933005: Distinguish between row (fragmentainer group) height and column (fragmentainer) height.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

Issue 2874933005: Distinguish between row (fragmentainer group) height and column (fragmentainer) height. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

index 9a3f9451868542675aed348fde6c988172759562..cb18996c3b174dfcea2080aa9b0e5ab58ce3ed57 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

@@ -159,7 +159,7 @@ class CORE_EXPORT LayoutMultiColumnSet : public LayoutBlockFlow {

// group can hold without overflowing.

LayoutUnit FragmentainerGroupCapacity(

const MultiColumnFragmentainerGroup& group) const {

- return group.LogicalHeight() * UsedColumnCount();

+ return group.ColumnLogicalHeight() * UsedColumnCount();

}

LayoutRect FlowThreadPortionRect() const;