third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp - Issue 2874933005: Distinguish between row (fragmentainer group) height and column (fragmentainer) height.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp

Issue 2874933005: Distinguish between row (fragmentainer group) height and column (fragmentainer) height. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp

diff --git a/third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp b/third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp

index 5001ea67a4e2086c29a550b39a99d9af7306c5a4..de39f5567ecb0dc0276cd043588081c2ab00f575 100644

--- a/third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp

+++ b/third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp

@@ -71,7 +71,7 @@ LayoutSize FragmentainerIterator::PaginationOffset() const {

const MultiColumnFragmentainerGroup& group = CurrentGroup();

LayoutUnit fragmentainer_logical_top_in_flow_thread =

group.LogicalTopInFlowThread() +

- current_fragmentainer_index_ * group.LogicalHeight();

+ current_fragmentainer_index_ * group.ColumnLogicalHeight();

return group.FlowThreadTranslationAtOffset(

fragmentainer_logical_top_in_flow_thread,

LayoutBox::kAssociateWithLatterPage, CoordinateSpaceConversion::kVisual);