chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm - Issue 2874923002: Omnibox UI Experiments: Port vertical margin experiment to Cocoa.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm

Issue 2874923002: Omnibox UI Experiments: Port vertical margin experiment to Cocoa. (Closed)

Patch Set: remove a pixel Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm

index dd2166485cf30444ff7f9f21d88af4ae5c79b358..ca66db2cf4d6bc966e97f3621cdcd0225630ed8d 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm

@@ -106,7 +106,7 @@ const NSInteger kMiddleButtonNumber = 2;

}

- (CGFloat)tableView:(NSTableView*)tableView heightOfRow:(NSInteger)row {

- CGFloat height = kContentLineHeight;

+ CGFloat height = [OmniboxPopupCell getContentTextHeight];

if ([[array_ objectAtIndex:row] isAnswer]) {

OmniboxPopupMatrix* matrix =

base::mac::ObjCCastStrict<OmniboxPopupMatrix>(tableView);