bluetooth: Implement simulateGATTConnectionResponse()

third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js

Index: third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
diff --git a/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js b/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
index 97919a8691d3bcc0d269fe6a4832f239646c09ce..26519e6913620a19fb30ddf198df9024857299b1 100644
--- a/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
+++ b/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
@@ -1,5 +1,11 @@
 'use strict';
 
+// HCI Error Codes. Used for simulateGATT[Dis]ConnectionResponse.
+// For a complete list of possible error codes see
+// BT 4.2 Vol 2 Part D 1.3 List Of Error Codes.
+const HCI_SUCCESS = 0x0000;
+const HCI_CONNECTION_TIMEOUT = 0x0008;
+
 // Bluetooth UUID constants:
 // Services:
 var blocklist_test_service_uuid = "611c954a-263b-4f4a-aab6-01ddb953f985";
@@ -447,3 +453,19 @@ function setUpHealthThermometerAndHeartRateDevices() {
        knownServiceUUIDs: ['generic_access', 'heart_rate'],
      })]));
 }
+
+function getConnectedHealthThermometerDevice(

[ortuno, 2017/05/12 00:53:44]

Forgot to mention this. This changes our testing pattern a bit. Before we could
set all the device's attributes and responses upfront so tests only needed to
call one function at the top. Now tests need to dispatch responses during the
test e.g. connect response after test calls gatt.connect(). Rather than trying
to simulate ON_CALL and make it so that a single call at the top would allow you
to call connect() and get a response in the test, I went with helper functions
that get you a device at the state where you want it e.g. a connected device in
this case.

The downside is that you can't see all steps in the test file. Upsides include
less complex Test API and tests are somewhat easier to read as they only contain
code relevant to the test.

+  options = {filters: [{services: ['health_thermometer']}]}) {
+  return setUpPreconnectedDevice({
+    address: '09:09:09:09:09:09',
+    name: 'Health Thermometer',
+    knownServiceUUIDs: ['generic_access', 'health_thermometer'],
+  })
+  .then(fake_peripheral => {
+    return requestDeviceWithKeyDown(options)

[scheib, 2017/05/12 05:43:56]

options parameter needed here ... because sometimes we'll need to set e.g.
optional services?

[ortuno, 2017/05/15 07:01:31]

Yeah, there are quite a few tests that check getPrimaryService(s) returns the
correct services based on the argument passed to requestDevice.

+      .then(device => Promise.all([
+        device.gatt.connect(),
+        fake_peripheral.simulateGATTConnectionResponse({code: HCI_SUCCESS})]))
+      .then(([gatt]) => [gatt.device, fake_peripheral]);
+  });
+}