third_party/WebKit/LayoutTests/bluetooth/server/connect/get-same-gatt-server.html - Issue 2874873003: bluetooth: Implement simulateGATTConnectionResponse()

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/server/connect/get-same-gatt-server.html

Issue 2874873003: bluetooth: Implement simulateGATTConnectionResponse() (Closed)

Patch Set: Merge branch 'bluetooth-generate-with-headers' into bluetooth-simulate-gatt-discovery-complete Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-error.html ('K') | « third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-success.html ('k') | third_party/WebKit/LayoutTests/bluetooth/server/device-same-object.html » ('j') | third_party/WebKit/LayoutTests/bluetooth/server/device-same-object.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/testharness.js"></script>	2 <script src="../../../resources/testharness.js"></script>

3 <script src="../../../resources/testharnessreport.js"></script>	3 <script src="../../../resources/testharnessreport.js"></script>

4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

	5 <script src="../../../resources/bluetooth/web-bluetooth-test.js"></script>

	6 <script src="../../../resources/mojo-helpers.js"></script>

5 <script>	7 <script>

6 'use strict';	8 'use strict';

7 promise_test(() => {	9 promise_test(() => {

8 return setBluetoothFakeAdapter('HeartRateAdapter')	10 return setUpHealthThermometerAndHeartRateDevices()

9 .then(() => requestDeviceWithKeyDown({	11 .then(([fake_peripheral]) => {

10 filters: [{services: ['heart_rate']}]}))	12 return requestDeviceWithKeyDown({

11 .then(device => {	13 filters: [{services: ['health_thermometer']}]})

12 return Promise.all([device.gatt.connect(), device.gatt.connect()])	14 .then(device => Promise.all([

13 }).then(gattServers => {	15 device.gatt.connect(),

14 assert_equals(gattServers[0], gattServers[1]);	16 device.gatt.connect(),

	17 fake_peripheral.simulateGATTConnectionResponse({code: HCI_SUCCESS}),
	scheib 2017/05/12 05:43:56 Not OK to have simulate calls in parallel to the c Not OK to have simulate calls in parallel to the connect() calls. Also, just one simulate(success) call should be needed. ortuno 2017/05/15 07:01:31 I don't think there is an alternative. The only al Show quoted text On 2017/05/12 at 05:43:56, scheib wrote: > Not OK to have simulate calls in parallel to the connect() calls. I don't think there is an alternative. The only alternative I can think of is equivalent to the current approach: .then(device => { let promise = Promise.all([device.gatt.connect(), device.gatt.connect()]); return fake_peripheral.simulateGATTConnectionResponse({code: HCI_SUCCESS}) .then(() => promise); }); That said, I've been putting off a change to allow FakeCentral to wait until it's observers have processed their own Mojo messages. That would guarantee that the connection request from connect() has arrived before we try to dispatch the simulated response. I'm currently working on a separate patch to add such a thing to Mojo. Show quoted text > Also, just one simulate(success) call should be needed. I'm happy to change it but I would like to understand why? The API is supposed to fake the OS's response and if we call connect twice on the OS I would expect two responses.
	18 fake_peripheral.simulateGATTConnectionResponse({code: HCI_SUCCESS}),

	19 ]))

	20 .then(([gattServer1, gattServer2]) => assert_equals(

	21 gattServer1, gattServer2));

15 });	22 });

16 }, 'Multiple connects should return the same gatt object.');	23 }, 'Multiple connects should return the same gatt object.');

17 </script>	24 </script>

OLD	NEW