third_party/WebKit/LayoutTests/bluetooth/server/connect/connection-succeeds.html - Issue 2874873003: bluetooth: Implement simulateGATTConnectionResponse()

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/server/connect/connection-succeeds.html

Issue 2874873003: bluetooth: Implement simulateGATTConnectionResponse() (Closed)

Patch Set: Merge branch 'bluetooth-generate-with-headers' into bluetooth-simulate-gatt-discovery-complete Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« device/bluetooth/test/fake_peripheral.cc ('K') | « third_party/WebKit/LayoutTests/bluetooth/script-tests/server/no-permission-for-any-service.js ('k') | third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-error.html » ('j') | third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-error.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/testharness.js"></script>	2 <script src="../../../resources/testharness.js"></script>

3 <script src="../../../resources/testharnessreport.js"></script>	3 <script src="../../../resources/testharnessreport.js"></script>

4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

	5 <script src="../../../resources/bluetooth/web-bluetooth-test.js"></script>

	6 <script src="../../../resources/mojo-helpers.js"></script>

5 <script>	7 <script>

6 'use strict';	8 'use strict';

7 promise_test(() => {	9 promise_test(() => {

8 return setBluetoothFakeAdapter('HeartRateAdapter')	10 return setUpHealthThermometerAndHeartRateDevices()
	scheib 2017/05/12 05:43:55 a) We should document what is returned by setUp... a) We should document what is returned by setUp....Devices methods. If we use this one we should capture the result as something specific 'thermometer_peripheral' since we know which one it is (I think). b) In this test, we don't need multiple devices, and I think we should simplify it to the generic flow you used elsewhere setUpPreconnectedDevice({}).then(device => requestDevice ... acceptAllDevices ortuno 2017/05/15 07:01:31 Makes sense. Added docs. Show quoted text On 2017/05/12 at 05:43:55, scheib wrote: > a) We should document what is returned by setUp....Devices methods. If we use this one we should capture the result as something specific 'thermometer_peripheral' since we know which one it is (I think). > Makes sense. Added docs. Show quoted text > b) In this test, we don't need multiple devices, and I think we should simplify it to the generic flow you used elsewhere > setUpPreconnectedDevice({}).then(device => > requestDevice ... acceptAllDevices I introduced getDiscoveredHealthThermometerDevice(). My current plan is to have the following functions: getHealthThermometerDevice(); getConnectedHealthThermometerDevice(); getDiscoveredHealthThermoemeterDevice(); getHealthThermometerDevice() will be similar to 'HeartRateAdapter'. It would return a connected BluetoothDevice where all attributes have been discovered. The other functions are for tests that require the device in an intermediate step e.g. getDiscoveredHealthThermometerDevice() returns a non-connected device, getConnectedHealthThermometerDevice() would return a connected device whose services haven't been discovered yet, etc. As I implement more features, I'll add them to the device returned by getHealthThermometerDevice() e.g. the next patch will add services.
9 .then(() => requestDeviceWithKeyDown({	11 .then(([fake_peripheral]) => {

10 filters: [{services: ['heart_rate']}]}))	12 return requestDeviceWithKeyDown({

11 .then(device => device.gatt.connect())	13 filters: [{services: ['health_thermometer']}]})

12 .then(gattServer => assert_true(gattServer.connected));	14 .then(device => Promise.all([

	15 device.gatt.connect(),

	16 fake_peripheral.simulateGATTConnectionResponse({code: HCI_SUCCESS})

	17 ]))

	18 .then(([gattServer]) => assert_true(gattServer.connected));

	19 });

13 }, 'Device will connect');	20 }, 'Device will connect');

14 </script>	21 </script>

OLD	NEW