Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: headless/public/util/generic_url_request_job_test.cc

Issue 2874843002: Shifted creation of unvalidated CanonicalCookies over to a constructor. (Closed)
Patch Set: Merged to top of dependent CL. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/net/quota_policy_cookie_store_unittest.cc ('k') | ios/net/cookies/cookie_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/public/util/generic_url_request_job_test.cc
diff --git a/headless/public/util/generic_url_request_job_test.cc b/headless/public/util/generic_url_request_job_test.cc
index 6c1327d1507dc32590bb277ba744f0258625a17d..39bdc6664a385b09125411170378ce21497897fa 100644
--- a/headless/public/util/generic_url_request_job_test.cc
+++ b/headless/public/util/generic_url_request_job_test.cc
@@ -366,7 +366,7 @@ TEST_F(GenericURLRequestJobTest, RequestWithCookies) {
net::CookieList* cookies = cookie_store_.cookies();
// Basic matching cookie.
- cookies->push_back(*net::CanonicalCookie::Create(
+ cookies->push_back(net::CanonicalCookie(
"basic_cookie", "1", ".example.com", "/", base::Time(), base::Time(),
base::Time(),
/* secure */ false,
@@ -374,7 +374,7 @@ TEST_F(GenericURLRequestJobTest, RequestWithCookies) {
net::COOKIE_PRIORITY_DEFAULT));
// Matching secure cookie.
- cookies->push_back(*net::CanonicalCookie::Create(
+ cookies->push_back(net::CanonicalCookie(
"secure_cookie", "2", ".example.com", "/", base::Time(), base::Time(),
base::Time(),
/* secure */ true,
@@ -382,7 +382,7 @@ TEST_F(GenericURLRequestJobTest, RequestWithCookies) {
net::COOKIE_PRIORITY_DEFAULT));
// Matching http-only cookie.
- cookies->push_back(*net::CanonicalCookie::Create(
+ cookies->push_back(net::CanonicalCookie(
"http_only_cookie", "3", ".example.com", "/", base::Time(), base::Time(),
base::Time(),
/* secure */ false,
@@ -390,7 +390,7 @@ TEST_F(GenericURLRequestJobTest, RequestWithCookies) {
net::COOKIE_PRIORITY_DEFAULT));
// Matching cookie with path.
- cookies->push_back(*net::CanonicalCookie::Create(
+ cookies->push_back(net::CanonicalCookie(
"cookie_with_path", "4", ".example.com", "/widgets", base::Time(),
base::Time(), base::Time(),
/* secure */ false,
@@ -398,7 +398,7 @@ TEST_F(GenericURLRequestJobTest, RequestWithCookies) {
net::COOKIE_PRIORITY_DEFAULT));
// Matching cookie with subdomain.
- cookies->push_back(*net::CanonicalCookie::Create(
+ cookies->push_back(net::CanonicalCookie(
"bad_subdomain_cookie", "5", ".cdn.example.com", "/", base::Time(),
base::Time(), base::Time(),
/* secure */ false,
@@ -406,7 +406,7 @@ TEST_F(GenericURLRequestJobTest, RequestWithCookies) {
net::COOKIE_PRIORITY_DEFAULT));
// Non-matching cookie (different site).
- cookies->push_back(*net::CanonicalCookie::Create(
+ cookies->push_back(net::CanonicalCookie(
"bad_site_cookie", "6", ".zombo.com", "/", base::Time(), base::Time(),
base::Time(),
/* secure */ false,
@@ -414,7 +414,7 @@ TEST_F(GenericURLRequestJobTest, RequestWithCookies) {
net::COOKIE_PRIORITY_DEFAULT));
// Non-matching cookie (different path).
- cookies->push_back(*net::CanonicalCookie::Create(
+ cookies->push_back(net::CanonicalCookie(
"bad_path_cookie", "7", ".example.com", "/gadgets", base::Time(),
base::Time(), base::Time(),
/* secure */ false,
« no previous file with comments | « content/browser/net/quota_policy_cookie_store_unittest.cc ('k') | ios/net/cookies/cookie_cache_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698