Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2874833005: SimpleCache: read small files all at once. (Closed)
Patch Set: Apply most of review feedback, still need to deal with the struct thing Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 8175033a9fc2daf4e31daee616ec6363b9e08221..8015b7c13fa32d2f45a2cc4253927c56d3af23fd 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -73732,6 +73732,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>The outcome of Entry::ReadData in the simple cache.</summary>
</histogram>
+<histogram base="true" name="SimpleCache.ReadStream1FromPrefetched"
+ enum="Boolean">
+ <owner>morlovich@chromium.org</owner>
+ <summary>
+ Whether a read from stream 1 was satisfied from prefetch data. Reported only
+ on first read op of entry (including if there are multiple readers, or even
+ some writers).
+ </summary>
+</histogram>
+
<histogram base="true" name="SimpleCache.StaleIndexExtraEntryCount"
units="entries">
<owner>gavinp@chromium.org</owner>
@@ -73814,6 +73824,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram base="true" name="SimpleCache.SyncOpenDidPrefetch" enum="Boolean">
+ <owner>morlovich@chromium.org</owner>
+ <summary>
+ Whether an attempt was made to prefetch the entire file when opening the
+ entry.
+ </summary>
+</histogram>
+
<histogram base="true" name="SimpleCache.SyncOpenEntryAge" units="hours">
<owner>gavinp@chromium.org</owner>
<summary>
@@ -90776,6 +90794,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<affected-histogram name="SimpleCache.QueueLatency.OpenEntry"/>
<affected-histogram name="SimpleCache.ReadIsParallelizable"/>
<affected-histogram name="SimpleCache.ReadResult"/>
+ <affected-histogram name="SimpleCache.ReadStream1FromPrefetched"/>
<affected-histogram name="SimpleCache.StaleIndexExtraEntryCount"/>
<affected-histogram name="SimpleCache.StaleIndexMissedEntryCount"/>
<affected-histogram name="SimpleCache.StaleIndexQuality"/>
@@ -90790,6 +90809,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<affected-histogram name="SimpleCache.SyncCreateResult_WithIndex"/>
<affected-histogram name="SimpleCache.SyncCreateResult_WithoutIndex"/>
<affected-histogram name="SimpleCache.SyncKeySHA256Result"/>
+ <affected-histogram name="SimpleCache.SyncOpenDidPrefetch"/>
<affected-histogram name="SimpleCache.SyncOpenEntryAge"/>
<affected-histogram name="SimpleCache.SyncOpenPlatformFileError"/>
<affected-histogram name="SimpleCache.SyncOpenPlatformFileError_WithIndex"/>

Powered by Google App Engine
This is Rietveld 408576698