Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2874833005: SimpleCache: read small files all at once. (Closed)
Patch Set: Add some metrics and an experiment knob. Not really happy with coverage, though. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« net/disk_cache/simple/simple_synchronous_entry.cc ('K') | « net/disk_cache/simple/simple_synchronous_entry.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 6c1a5189d1c43e320e0b0a4193ac8cb36fd1092d..fdfe74f7b5bc9f8c55df06c8fdf8877c7e95adf7 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -72113,6 +72113,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>The outcome of Entry::ReadData in the simple cache.</summary>
</histogram>
+<histogram base="true" name="SimpleCache.ReadStream1FromPrefetched"
+ enum="Boolean">
+ <owner>morlovich@chromium.org</owner>
+ <summary>
+ Whether a read from stream 1 was satisfied from prefetch data. Reported only
+ on first read op.
+ </summary>
+</histogram>
+
<histogram base="true" name="SimpleCache.StaleIndexExtraEntryCount"
units="entries">
<owner>gavinp@chromium.org</owner>
@@ -72195,6 +72204,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram base="true" name="SimpleCache.SyncOpenDidPrefetch" enum="Boolean">
+ <owner>morlovich@chromium.org</owner>
+ <summary>
+ Whether an attempt was made to prefetch the entire file when opening the
+ entry.
+ </summary>
+</histogram>
+
<histogram base="true" name="SimpleCache.SyncOpenEntryAge" units="hours">
<owner>gavinp@chromium.org</owner>
<summary>
@@ -88705,6 +88722,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<affected-histogram name="SimpleCache.QueueLatency.OpenEntry"/>
<affected-histogram name="SimpleCache.ReadIsParallelizable"/>
<affected-histogram name="SimpleCache.ReadResult"/>
+ <affected-histogram name="SimpleCache.ReadStream1FromPrefetched"/>
<affected-histogram name="SimpleCache.StaleIndexExtraEntryCount"/>
<affected-histogram name="SimpleCache.StaleIndexMissedEntryCount"/>
<affected-histogram name="SimpleCache.StaleIndexQuality"/>
@@ -88719,6 +88737,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<affected-histogram name="SimpleCache.SyncCreateResult_WithIndex"/>
<affected-histogram name="SimpleCache.SyncCreateResult_WithoutIndex"/>
<affected-histogram name="SimpleCache.SyncKeySHA256Result"/>
+ <affected-histogram name="SimpleCache.SyncOpenDidPrefetch"/>
<affected-histogram name="SimpleCache.SyncOpenEntryAge"/>
<affected-histogram name="SimpleCache.SyncOpenPlatformFileError"/>
<affected-histogram name="SimpleCache.SyncOpenPlatformFileError_WithIndex"/>
« net/disk_cache/simple/simple_synchronous_entry.cc ('K') | « net/disk_cache/simple/simple_synchronous_entry.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698