Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 287483002: goobspatch: Improve sanity checks for invalid patches. (Closed)

Created:
6 years, 7 months ago by deymo
Modified:
6 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

goobspatch: Improve sanity checks for invalid patches. This patch checks that the length passed to cfread() is non negative. The individual read methods on cfread() check for failure while reading a negative value, but the actual failure is a malformed patch. R=mark@chromium.org BUG=chromium:372525 TEST=Manually run a local bad patch and check it fails with the new message. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269935

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/installer/mac/third_party/bsdiff/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/mac/third_party/bsdiff/goobspatch.c View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Mentovai
Great catch!
6 years, 7 months ago (2014-05-12 19:57:47 UTC) #1
Mark Mentovai
LGTM
6 years, 7 months ago (2014-05-12 19:57:51 UTC) #2
deymo
The CQ bit was checked by deymo@chromium.org
6 years, 7 months ago (2014-05-12 20:15:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deymo@chromium.org/287483002/1
6 years, 7 months ago (2014-05-12 20:15:43 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 00:19:39 UTC) #5
Message was sent while issue was closed.
Change committed as 269935

Powered by Google App Engine
This is Rietveld 408576698