Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2874813002: Support configuring DDC runtime settings before the application starts and normalize API for config… (Closed)

Created:
3 years, 7 months ago by Jacob
Modified:
3 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support configuring DDC runtime settings before the application starts and normalize API for configuring runtime settings. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/a35b79f17897c97a6c61149bd138aff7f1c22a39

Patch Set 1 #

Patch Set 2 : Support configuring DDC runtime settings before the application starts and normalize API for config… #

Total comments: 2

Patch Set 3 : Support configuring DDC runtime settings before the application starts and normalize API for config… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 2 Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/profile.dart View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart View 1 2 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jacob
3 years, 7 months ago (2017-05-10 16:37:40 UTC) #2
vsm
lgtm https://codereview.chromium.org/2874813002/diff/10001/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart (right): https://codereview.chromium.org/2874813002/diff/10001/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart#newcode93 pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart:93: // These settings must be configured before the ...
3 years, 7 months ago (2017-05-10 16:42:05 UTC) #3
Jacob
https://codereview.chromium.org/2874813002/diff/10001/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart (right): https://codereview.chromium.org/2874813002/diff/10001/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart#newcode93 pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart:93: // These settings must be configured before the application ...
3 years, 7 months ago (2017-05-10 17:05:27 UTC) #4
Jacob
3 years, 7 months ago (2017-05-10 17:05:58 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:20001) manually as
a35b79f17897c97a6c61149bd138aff7f1c22a39 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698