Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Unified Diff: runtime/vm/stub_code_arm.cc

Issue 2874763003: Add AddImmediate(reg, int) to ARM64 assembler (Closed)
Patch Set: Fix bug Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intrinsifier_arm64.cc ('k') | runtime/vm/stub_code_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_arm.cc
diff --git a/runtime/vm/stub_code_arm.cc b/runtime/vm/stub_code_arm.cc
index 47d6fa232fe6686b9c025663a3c64a8eecb956e7..31f70e1928c7930bf098a23ad6a0e7e7725acbd5 100644
--- a/runtime/vm/stub_code_arm.cc
+++ b/runtime/vm/stub_code_arm.cc
@@ -479,7 +479,7 @@ static void GenerateDeoptimizationSequence(Assembler* assembler,
__ vstmd(DB_W, SP, D0, kNumberOfDRegisters);
}
} else {
- __ AddImmediate(SP, SP, -kNumberOfFpuRegisters * kFpuRegisterSize);
+ __ AddImmediate(SP, -kNumberOfFpuRegisters * kFpuRegisterSize);
}
__ mov(R0, Operand(SP)); // Pass address of saved registers block.
@@ -845,7 +845,7 @@ void StubCode::GenerateInvokeDartCodeStub(Assembler* assembler) {
// Compute address of 'arguments array' data area into R2.
__ ldr(R2, Address(R2, VMHandles::kOffsetOfRawPtrInHandle));
- __ AddImmediate(R2, R2, Array::data_offset() - kHeapObjectTag);
+ __ AddImmediate(R2, Array::data_offset() - kHeapObjectTag);
// Set up arguments for the Dart call.
Label push_arguments;
@@ -1337,7 +1337,7 @@ static void EmitFastSmiOp(Assembler* assembler,
// R9: IC data object (preserved).
__ ldr(R8, FieldAddress(R9, ICData::ic_data_offset()));
// R8: ic_data_array with check entries: classes and target functions.
- __ AddImmediate(R8, R8, Array::data_offset() - kHeapObjectTag);
+ __ AddImmediate(R8, Array::data_offset() - kHeapObjectTag);
// R8: points directly to the first ic data array element.
#if defined(DEBUG)
// Check that first entry is for Smi/Smi.
@@ -1636,7 +1636,7 @@ void StubCode::GenerateZeroArgsUnoptimizedStaticCallStub(Assembler* assembler) {
// R9: IC data object (preserved).
__ ldr(R8, FieldAddress(R9, ICData::ic_data_offset()));
// R8: ic_data_array with entries: target functions and count.
- __ AddImmediate(R8, R8, Array::data_offset() - kHeapObjectTag);
+ __ AddImmediate(R8, Array::data_offset() - kHeapObjectTag);
// R8: points directly to the first ic data array element.
const intptr_t target_offset = ICData::TargetIndexFor(0) * kWordSize;
const intptr_t count_offset = ICData::CountIndexFor(0) * kWordSize;
@@ -2155,7 +2155,7 @@ void StubCode::GenerateICCallThroughFunctionStub(Assembler* assembler) {
Label loop, found, miss;
__ ldr(R4, FieldAddress(R9, ICData::arguments_descriptor_offset()));
__ ldr(R8, FieldAddress(R9, ICData::ic_data_offset()));
- __ AddImmediate(R8, R8, Array::data_offset() - kHeapObjectTag);
+ __ AddImmediate(R8, Array::data_offset() - kHeapObjectTag);
// R8: first IC entry
__ LoadTaggedClassIdMayBeSmi(R1, R0);
// R1: receiver cid as Smi
@@ -2190,7 +2190,7 @@ void StubCode::GenerateICCallThroughCodeStub(Assembler* assembler) {
Label loop, found, miss;
__ ldr(R4, FieldAddress(R9, ICData::arguments_descriptor_offset()));
__ ldr(R8, FieldAddress(R9, ICData::ic_data_offset()));
- __ AddImmediate(R8, R8, Array::data_offset() - kHeapObjectTag);
+ __ AddImmediate(R8, Array::data_offset() - kHeapObjectTag);
// R8: first IC entry
__ LoadTaggedClassIdMayBeSmi(R1, R0);
// R1: receiver cid as Smi
« no previous file with comments | « runtime/vm/intrinsifier_arm64.cc ('k') | runtime/vm/stub_code_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698