Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: pkg/front_end/lib/src/incremental_kernel_generator_impl.dart

Issue 2874723002: Add a way to use shared CanonicalName root to deserialize Program. (Closed)
Patch Set: Always compute canonical names. Use shared name root. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 6
7 import 'package:front_end/file_system.dart'; 7 import 'package:front_end/file_system.dart';
8 import 'package:front_end/incremental_kernel_generator.dart'; 8 import 'package:front_end/incremental_kernel_generator.dart';
9 import 'package:front_end/incremental_resolved_ast_generator.dart'; 9 import 'package:front_end/incremental_resolved_ast_generator.dart';
10 import 'package:front_end/src/base/processed_options.dart'; 10 import 'package:front_end/src/base/processed_options.dart';
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 Uri fileUri = _uriTranslator.translate(absoluteUri); 98 Uri fileUri = _uriTranslator.translate(absoluteUri);
99 await _fsState.getFile(fileUri); 99 await _fsState.getFile(fileUri);
100 } 100 }
101 } 101 }
102 102
103 /// Return the [DillTarget] that is used inside of [KernelTarget] to 103 /// Return the [DillTarget] that is used inside of [KernelTarget] to
104 /// resynthesize SDK libraries. 104 /// resynthesize SDK libraries.
105 Future<DillTarget> _getSdkDillTarget() async { 105 Future<DillTarget> _getSdkDillTarget() async {
106 if (_sdkDillTarget == null) { 106 if (_sdkDillTarget == null) {
107 _sdkDillTarget = 107 _sdkDillTarget =
108 new DillTarget(new Ticker(isVerbose: false), _uriTranslator); 108 new DillTarget(null, new Ticker(isVerbose: false), _uriTranslator);
109 // TODO(scheglov) Read the SDK kernel. 109 // TODO(scheglov) Read the SDK kernel.
110 // _sdkDillTarget.read(options.sdkSummary); 110 // _sdkDillTarget.read(options.sdkSummary);
111 // await _sdkDillTarget.writeOutline(null); 111 // await _sdkDillTarget.writeOutline(null);
112 } else { 112 } else {
113 // Program sdkProgram = _sdkDillTarget.loader.program; 113 // Program sdkProgram = _sdkDillTarget.loader.program;
114 // sdkProgram.visitChildren(new _ClearCanonicalNamesVisitor()); 114 // sdkProgram.visitChildren(new _ClearCanonicalNamesVisitor());
115 } 115 }
116 return _sdkDillTarget; 116 return _sdkDillTarget;
117 } 117 }
118 118
119 /// Refresh all the invalidated files and update dependencies. 119 /// Refresh all the invalidated files and update dependencies.
120 Future<Null> _refreshInvalidatedFiles() async { 120 Future<Null> _refreshInvalidatedFiles() async {
121 for (Uri fileUri in _invalidatedFiles) { 121 for (Uri fileUri in _invalidatedFiles) {
122 FileState file = await _fsState.getFile(fileUri); 122 FileState file = await _fsState.getFile(fileUri);
123 await file.refresh(); 123 await file.refresh();
124 } 124 }
125 _invalidatedFiles.clear(); 125 _invalidatedFiles.clear();
126 } 126 }
127 } 127 }
128 128
129 ///// Clears canonical names of [NamedNode] references. 129 ///// Clears canonical names of [NamedNode] references.
130 //class _ClearCanonicalNamesVisitor extends Visitor { 130 //class _ClearCanonicalNamesVisitor extends Visitor {
131 // defaultNode(Node node) { 131 // defaultNode(Node node) {
132 // if (node is NamedNode) { 132 // if (node is NamedNode) {
133 // node.reference.canonicalName = null; 133 // node.reference.canonicalName = null;
134 // } 134 // }
135 // node.visitChildren(this); 135 // node.visitChildren(this);
136 // } 136 // }
137 //} 137 //}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698