Issue 2874713005: Disambiguate setters and getters when patching DDC SDK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2874713005: Disambiguate setters and getters when patching DDC SDK. (Closed)

Created:
3 years, 7 months ago by Bob Nystrom

Modified:
3 years, 7 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Disambiguate setters and getters when patching DDC SDK. Stdio was having its setters applied twice instead of applying the getter and setter each once. R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/a68b44924edad452e44e6e7139693641773df2ec

Created: 3 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -6 lines)			Patch
M	pkg/dev_compiler/lib/sdk/ddc_sdk.sum	View	Binary file		0 comments	Download
M	pkg/dev_compiler/tool/patch_sdk.dart	View	1 chunk	+13 lines, -3 lines	0 comments	Download
M	pkg/dev_compiler/tool/sdk_expected_errors.txt	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

Bob Nystrom

3 years, 7 months ago (2017-05-10 23:56:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a68b44924edad452e44e6e7139693641773df2ec (presubmit successful).