Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9275)

Unified Diff: chrome/renderer/page_load_metrics/page_timing_metrics_sender.h

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
diff --git a/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h b/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
index fc3fba1f51412bc22ab5a8d28e099db496ea333b..3faf59e62323b77be65d882e27ce2cb305c634c3 100644
--- a/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
+++ b/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
@@ -26,14 +26,15 @@ namespace page_load_metrics {
// minimize IPC contention.
class PageTimingMetricsSender {
public:
- PageTimingMetricsSender(IPC::Sender* ipc_sender,
- int routing_id,
- std::unique_ptr<base::Timer> timer,
- const PageLoadTiming& initial_timing);
+ PageTimingMetricsSender(
+ IPC::Sender* ipc_sender,
+ int routing_id,
+ std::unique_ptr<base::Timer> timer,
+ mojo::StructPtr<mojom::PageLoadTiming> initial_timing);
~PageTimingMetricsSender();
void DidObserveLoadingBehavior(blink::WebLoadingBehaviorFlag behavior);
- void Send(const PageLoadTiming& timing);
+ void Send(mojo::StructPtr<mojom::PageLoadTiming> timing);
protected:
base::Timer* timer() const { return timer_.get(); }
@@ -45,11 +46,11 @@ class PageTimingMetricsSender {
IPC::Sender* const ipc_sender_;
const int routing_id_;
std::unique_ptr<base::Timer> timer_;
- PageLoadTiming last_timing_;
+ mojo::StructPtr<mojom::PageLoadTiming> last_timing_;
// The the sender keep track of metadata as it comes in, because the sender is
// scoped to a single committed load.
- PageLoadMetadata metadata_;
+ mojom::PageLoadMetadata metadata_;
DISALLOW_COPY_AND_ASSIGN(PageTimingMetricsSender);
};

Powered by Google App Engine
This is Rietveld 408576698