Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2447)

Unified Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
diff --git a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
index 3b9ad1e915cf3a676e7ba8a0557378eea7038a91..70ad64d417a1f1eac5f147741961aeea6a72a829 100644
--- a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
+++ b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
@@ -48,7 +48,7 @@ class MetricsRenderFrameObserver : public content::RenderFrameObserver {
void SendMetrics();
virtual bool ShouldSendMetrics() const;
- virtual PageLoadTiming GetTiming() const;
+ virtual mojo::StructPtr<mojom::PageLoadTiming> GetTiming() const;
Ken Rockot(use gerrit already) 2017/05/15 17:26:34 nit: please use mojom::PageLoadTimingPtr instead o
Bryan McQuade 2017/05/15 17:38:24 FWIW, I worry a little bit about using PageLoadTim
lpy 2017/05/15 22:40:18 Done.
virtual std::unique_ptr<base::Timer> CreateTimer() const;
virtual bool HasNoRenderFrame() const;
virtual bool IsMainFrame() const;

Powered by Google App Engine
This is Rietveld 408576698